D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:83ef545a35ab: Make the Trashcan applet use the same shadow settings as desktop icons (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D215

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > filipf wrote in main.qml:154 > Should I copy all of the code from `FolderItemDelegate.qml`? It's: > > `width: Math.round(Math.min(label.implicitWidth + units.smallSpacing, > parent.width - units.smallSpacing))` Not necessary since this is a free

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf added inline comments. INLINE COMMENTS > main.qml:154 > } > +width: Math.round(text.implicitWidth + units.smallSpacing) // make > sure label is not blurry > text: (dirModel.count === 0) ? i18n("Trash\nEmpty") : > i18np("Trash\nOne item", "Trash\n %1 items", dirM

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Huh, how about that. Stable branch please. REPOSITORY R119 Plasma Desktop BRANCH trashcan-consistent-shadows (branched from master) REVISION DETAIL https://phabricator.kde.org

D21545: Make the Trashcan applet use the same shadow settings as desktop icons

2019-06-02 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We changed desktop shadows in 10278e79f116 , but we also