This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R112:c918c2840bcb: Dont give up if no results arrive
after 500ms (authored by fvogt).
REPOSITORY
R112 Milou
CHANGES
fvogt updated this revision to Diff 59789.
fvogt marked an inline comment as done.
fvogt added a comment.
Remove whitespace change. Will land on Monday if no objections.
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21605?vs=59204=59789
BRANCH
dontgiveup
fvogt marked 2 inline comments as done.
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in sourcesmodel.h:93
> more like a flags thing :), also `TODO Plasma 6` this way round pls
Done differently now. It's not like the added function would've been useful to
call from the outside
fvogt updated this revision to Diff 59204.
fvogt added a comment.
Code duplication is better than polluting the API.
REPOSITORY
R112 Milou
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21605?vs=59201=59204
BRANCH
Plasma/5.12
REVISION DETAIL
broulik added a comment.
Does that by chance also fix the dictionary runner which does network queries
that take a while?
INLINE COMMENTS
> sourcesmodel.h:93
> + * Clears the model content and resets the runner context, i.e. no new
> items appear.
> + * Plasma 6 TODO: Replace this
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.
REVISION SUMMARY
Currently it resets the entire context if no results appear after 500ms,
which means no new results
