D21646: re-read color palettes when application color changes

This revision was automatically updated to reflect the committed changes. Closed by commit R31:092d44603cef: re-read color palettes when application color changes (authored by sebas). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59333=59344 REVISION

D21646: re-read color palettes when application color changes

sebas added a comment. @sitter here's a review sending the reparseConfiguration signal from the Colors KCM. Thanks for the review, all! REPOSITORY R31 Breeze BRANCH colorchangeeventfilter REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma, broulik, sitter Cc:

D21646: re-read color palettes when application color changes

sitter accepted this revision. sitter added a comment. LGTM. At a glance breezehelper caches values (loadConfig) and brezestyleconfigdata may as well, so this certainly seems sound. Specifically ` _viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor, _config

D21646: re-read color palettes when application color changes

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. You need to run `arc amend` to reflect the change to the commit message in your local checkout REPOSITORY R31 Breeze BRANCH colorchangeeventfilter REVISION DETAIL

D21646: re-read color palettes when application color changes

sebas added a comment. Done (assuming editing the phab description is enough). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21646: re-read color palettes when application color changes

cfeck added a comment. There will be no further 5.15 release. Please set to 5.16 branch (and merge to master when ready). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh,

D21646: re-read color palettes when application color changes

sebas updated this revision to Diff 59333. sebas added a comment. - Qt4 compat REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59332=59333 BRANCH colorchangeeventfilter REVISION DETAIL https://phabricator.kde.org/D21646 AFFECTED FILES

D21646: re-read color palettes when application color changes

broulik added inline comments. INLINE COMMENTS > breezestyle.cpp:201 > > +connect(qApp, ::paletteChanged, this, > ::configurationChanged); > + Wrap in `#if !BREEZE_USE_KDE4` REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc:

D21646: re-read color palettes when application color changes

sebas updated this revision to Diff 59332. sebas added a comment. - use QApplication::paletteChanged as Kai suggests REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59330=59332 BRANCH colorchangeeventfilter REVISION DETAIL

D21646: re-read color palettes when application color changes

broulik added inline comments. INLINE COMMENTS > breezestyle.h:163 > object->installEventFilter( this ); > +qApp->installEventFilter( this ); > } Try connecting to `QGuiApplication::paletteChanged`. I added that signal specifically so that you avoid having to

D21646: re-read color palettes when application color changes

zzag added a comment. A bit noob-ish question: can we listen to paletteChanged signal instead? e.g. connect(qApp, ::paletteChanged, this, ::configurationChanged); REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: zzag, plasma-devel,

D21646: re-read color palettes when application color changes

sebas created this revision. sebas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Without this patch, changing the application color scheme from system settings only affects some