D21668: WIP: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59688. filipf added a comment. make the form layouts respond to window resizing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59682=59688 BRANCH modernize-redesign-nightcolor-config (branched from

D21668: WIP: Modernize and redesign the Night Color config window

ngraham added a comment. If I had to guess, it's because they're inside a column that doesn't span the full width of the page. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21668 To: filipf, #vdg, ngraham, romangg, mart, #plasma Cc: davidedmundson,

D21668: WIP: Modernize and redesign the Night Color config window

filipf added a comment. In D21668#478822 , @davidedmundson wrote: > > getting there; all is aligned now, it's just that the content needs to be unstiffened > > What does that mean > > Please remove the WIP tag when things are ready for

D21668: WIP: Modernize and redesign the Night Color config window

davidedmundson added a comment. > getting there; all is aligned now, it's just that the content needs to be unstiffened What does that mean Please remove the WIP tag when things are ready for review. Generally this looks good to me, ++ REPOSITORY R119 Plasma Desktop

D21668: WIP: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59682. filipf added a comment. getting there; all is aligned now, it's just that the content needs to be unstiffened REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59404=59682 BRANCH

D21668: WIP: Modernize and redesign the Night Color config window

filipf added a comment. OK, so everything works nice if the form layouts simply reside in main.qml as components. It's when we spawn them through loaders that we get binding loops and misalignment (even if twinFormLayouts is specified!). The loader is not specifying geometry to the layouts

D21668: WIP: Modernize and redesign the Night Color config window

filipf added a comment. In D21668#476358 , @ngraham wrote: > Lovely! Can you align the bottom fields with the combobox above them? I tried to do that with twinFormLayouts but it creates binding loop problems that can even be traced back

D21668: WIP: Modernize and redesign the Night Color config window

ngraham added a comment. Lovely! Can you align the bottom fields with the combobox above them? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21668 To: filipf, #vdg, ngraham, romangg, mart Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen,

D21668: WIP: Modernize and redesign the Night Color config window

filipf added inline comments. INLINE COMMENTS > main.qml:23 > import org.kde.plasma.core 2.0 as PlasmaCore > -import org.kde.plasma.extras 2.0 as PlasmaExtras > +import org.kde.plasma.extras 2.0 as PlasmaExtras*/ > +import org.kde.kirigami 2.5 as Kirigami Are these 3 imports needed? I couldn't

D21668: WIP: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59404. filipf added a comment. initial cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59403=59404 BRANCH modernize-redesign-nightcolor-config (branched from master) REVISION DETAIL

D21668: WIP: Modernize and redesign the Night Color config window

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Port to Kirigami FormLayout and QQC2. NOTE: There are some heavy binding loop errors about "implicitWidth" due to loading more