D21797: do not set a hardcoded minimum size

This revision was automatically updated to reflect the committed changes. Closed by commit R871:fdff5bd4bc20: do not set a hardcoded minimum size (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21797?vs=59989=60721 REVISION DETAIL

D21797: do not set a hardcoded minimum size

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY R871 DrKonqi BRANCH minimums REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma, apol Cc: apol, cfeck, plasma-devel, LeGast00n, jraleigh,

D21797: do not set a hardcoded minimum size

sitter added a comment. Oh, FWIW, I am not sure if defaulting to 16:9 on the report dialog is actually all that awesome, it seems to cause an exhaustive amount of empty space for the most part. Opinions welcome. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797

D21797: do not set a hardcoded minimum size

sitter updated this revision to Diff 59989. sitter added a comment. expand diff based on additional pondering - both dialogs now throw away their minimum size - the resize calls are gone too - instead we now calculate a 16:9 size based off of the sizeHint and resize to that (keeps

D21797: do not set a hardcoded minimum size

sitter added a comment. In D21797#479670 , @cfeck wrote: > so its minimum size is its minimum with and its minimum height Sure, unless the Policy is Minimum/MinimumExpanding, which I think it would need to be in our case when wrapping is

D21797: do not set a hardcoded minimum size

cfeck added a comment. If the backtrace is filled later, and that would cause the minimumSize to change, then it will automatically get propagated to the window. A wordwrapped label is supposed to adapt to any with _or_ any height, so its minimum size is its minimum with and its minimum

D21797: do not set a hardcoded minimum size

sitter added a comment. Pre-computation is not going to work 100% because the backtracewidget is actually changing its content based on state (a whole other can of worms that :S). What's the specific problem with wrapped qlabels though? Shouldn't they still correctly hint? I mean, the

D21797: do not set a hardcoded minimum size

cfeck added a comment. I guess sizeHint() from a paged dialog doesn't pick all pages, so the correct way to resolve this issue is to iterate over all pages, compute their sizeHint(), and use the combined size as the minium size, see `QSize::expandedTo()`. REPOSITORY R871 DrKonqi

D21797: do not set a hardcoded minimum size

cfeck added a comment. I think I now see why we messed with sizes. There are wrapped QLabels in the dialog, and these break minimum size hints. What we generally do to resolve this issue is to use `setMinimumSize(sizeHint())`. REPOSITORY R871 DrKonqi REVISION DETAIL

D21797: do not set a hardcoded minimum size

sitter added a comment. Practically right now nothing, technically I think (?) Qt goes for the sizeHint() by default, so in theory the resize may have an effect. That said, I am not opposed to dropping that call as well if we can agree on that. REPOSITORY R871 DrKonqi REVISION DETAIL

D21797: do not set a hardcoded minimum size

cfeck added a comment. What happens if you (instead/also) remove the next line? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21797: do not set a hardcoded minimum size

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY setting the minimum size manually like this is overriding the actual calculated minimum size (as