D21811: [Calculator] Fix popup size and minimum size for expanded version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ba5d35dfe829: [Calculator] Fix popup size and minimum size for expanded version (authored by ngraham). REPOSITORY

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham updated this revision to Diff 60312. ngraham added a comment. Just use a reasonable hardcoded size, per @davidedmundson's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21811?vs=59830=60312 BRANCH fix-calculator-popup (branched

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham added inline comments. INLINE COMMENTS > broulik wrote in calculator.qml:42 > Maybe just fixing this to be `units.gridUnit` times some larger value could > fix the initial sizing I tried that earlier, but while it works for the expanded version when the widget is in the panel, it

D21811: [Calculator] Fix popup size and minimum size for expanded version

broulik added inline comments. INLINE COMMENTS > calculator.qml:42 > > width: units.gridSize * 3 > height: units.gridSize * 4 Maybe just fixing this to be `units.gridUnit` times some larger value could fix the initial sizing REPOSITORY R114 Plasma Addons REVISION DETAIL

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham created this revision. ngraham added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In D21503 , I messed up the popup size and