D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

filipf added a comment. Users shouldn't be creating random files in this directory. But if considering the possibility, according to tests configs are ordered alphabetically so we'd need to have a z_kde_settings.conf (if not intervening in SDDM). REPOSITORY R123 SDDM Configuration

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

sitter added a comment. I would actually note that the file should be `0_kde_settings.conf` (assuming/hoping sddm orders the configs) otherwise a user can manually create `best_config.conf` and get overridden by what was set in the KCM what with `k` being loaded after `b`. REPOSITORY

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

fvogt added a comment. I argued in https://bugs.kde.org/show_bug.cgi?id=386241 that this is the wrong way. Any reason you implemented this anyway? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham,

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

This revision was automatically updated to reflect the committed changes. Closed by commit R123:3e3dbbb2fbd3: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

filipf marked an inline comment as done. filipf added a comment. In D21832#480344 , @GB_2 wrote: > I think `plasma-settings.conf` is a better filename. Probably, but I'm not sure it's super important have the distinction in this case.

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

ngraham accepted this revision. ngraham added a comment. Nice work! REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham, #plasma Cc: GB_2, plasma-devel,

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

GB_2 added a comment. I think `plasma-sddm.conf` is a better filename. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham, #plasma Cc: GB_2,

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff, thanks REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL