D21884: [Touchpad KCM] Do not crash in case there is no touchpad

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7127724309a: [Touchpad KCM] Do not crash in case there is no touchpad (authored by beischer, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21884?vs=60026&id=60077#toc

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. Doing it! REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampalo

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg accepted this revision. romangg added a comment. Yes, let's do that. Add a comment to the code that we fallback to evdev for now if no touchpad is connected and we want to show instead libinput in the future when the issues have been resolved. REPOSITORY R119 Plasma Desktop BRANCH

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham accepted this revision. ngraham added a comment. Shall we land this now and refine the behavior later? REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma, da

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. > 1. Controls not disabled > 2. "Two-finger-tap" radio buttons are missing their labels > 3. Middle-click label missing its radio buttons > > And then of course, unrelated to this patch or bug, is https://bugs.kde.org/show_bug.cgi?id=407464 Yes, thats

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. In D21884#481680 , @romangg wrote: > What does not look right to you there? Are the controls greyed out? 1. Controls not disabled 2. "Two-finger-tap" radio buttons are missing their labels 3. Middle-click

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481572 , @beischer wrote: > That doesn't look right to me? Maybe because TouchpadConfigContainer::kcmInit() is a no-op (first because the mode is Unset, so neither of the two if branches triggers, but even if t

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. In D21884#481568 , @romangg wrote: > Ok, that would be even better. Only drawback is then that it shows the "wrong" interface in case libinput is used until a touchpad is plugged, but that's such an uncommon case that I

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481567 , @beischer wrote: > Roman, with this patch the box with 'No touchpad found' is shown under X11, too: > > F6907948: no_touchpad.png > > Since I'm not the aut

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. Roman, with this patch the box with 'No touchpad found' is shown under X11, too: F6907948: no_touchpad.png Since I'm not the author of the code my intention was to fix the bug with as little side effects as possible. I

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. On Wayland it shows a message that no touchpad is connected. Would it be possible on X to determine if a to-be-connected touchpad would use libinput or Xlib (although the use case is pretty rare of a detechable touchpad)? REPOSITORY R119 Plasma Desktop BRANCH bu

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, so we show a backend that will do nothing instead? That doesn't sound like the right long term approach. Will do for backporting into stable. REPOSITORY R119 Pl

D21884: [Touchpad KCM] Do not crash in case there is no touchpad.

beischer created this revision. beischer added reviewers: ngraham, romangg, atulbi, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. beischer requested review of this revision. REVISION SUMMARY Fixes bug #4083250. REPOSITORY R119 Plasma Desktop BRANCH bug-40