D21944: Show shortcut in menu item when specified

This revision was automatically updated to reflect the committed changes. Closed by commit R858:721c348d1a1e: Show shortcut in menu item when specified (authored by astippich). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=

D21944: Show shortcut in menu item when specified

ngraham added a comment. @apol, is this good to go now? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, mart, ngraham, apol Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himc

D21944: Show shortcut in menu item when specified

astippich added a comment. Unfortunately, even with this reverted change I know get a wrong menu separator. I don't know what was different before... Since it was also there without this patch (see screenshot), it is probably a different issue which needs investigation REPOSITORY R858

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60332. astippich added a comment. - use item for margin again REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60300&id=60332 BRANCH menu_item REVISION DETAIL https://phabricato

D21944: Show shortcut in menu item when specified

ngraham added inline comments. INLINE COMMENTS > apol wrote in MenuItem.qml:103 > Use Layout.rightMargin on the shortcut object. > https://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#rightMargin-attached-prop I think the original approach to use an Item was correct, both because now it looks

D21944: Show shortcut in menu item when specified

astippich added a comment. The menu separator now does not look correct: F6923245: menu_after2.png I don't know why REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, mart, ngraha

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60300. astippich added a comment. - simplify REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60162&id=60300 BRANCH menu_item REVISION DETAIL https://phabricator.kde.org/D21944

D21944: Show shortcut in menu item when specified

apol added inline comments. INLINE COMMENTS > MenuItem.qml:98 > +font: controlRoot.font > +color: (controlRoot.highlighted || controlRoot.hovered) ? > Kirigami.Theme.highlightedTextColor : Kirigami.Theme.textColor > +horizontalAlignment: Text.AlignRight label

D21944: Show shortcut in menu item when specified

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent. Looks like a sane way to do it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH menu_item REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, ma

D21944: Show shortcut in menu item when specified

astippich added a comment. This is required to port the menu of Elisa to qqc2 (D21943 ) qqc1 version F6918483: menu_qqc1.png qqc2 version without this patch F6918485: menu_before.png

D21944: Show shortcut in menu item when specified

astippich created this revision. astippich added reviewers: mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Show the shortcut as text for menu items when they are given via an action REPOSIT