D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. In D22210#547637 , @davidedmundson wrote: > 1. A period where both X and wayland say "Plasma". > > 1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson accepted this revision. davidedmundson added a comment. +1 but wait for fvogt and whoever else to ack. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt Cc: ngraham, pino, rdieter,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner updated this revision to Diff 67992. asturmlechner added a comment. Switch back to Plasma (Wayland) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=62165=67992 BRANCH arcpatch-D22210 REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. In D22210#547637 , @davidedmundson wrote: > Ok, so there are exactly 3 outcomes of events. > > 1. A period where both X and wayland say "Plasma". > 2. A period where we see Plasma (X11) and Plasma > 3. A period

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson added a comment. Ok, so there are exactly 3 outcomes of events. 1. A period where both X and wayland say "Plasma". 2. A period where we see Plasma (X11) and Plasma 3. A period where we see Plasma (wayland) (wayland) (a combo of 2 & 3 is also possible, but that

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. In D22210#547621 , @ngraham wrote: > "Plasma on Xorg" is a yucky string to display to users. well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. Got it. My very strong preference is to append the session name for Wayland, not X11. "Plasma on Xorg" is a yucky string to display to users. IMO it would be preferable to display "Plasma on Wayland (Wayland) for a limited period of time while the Plasma and

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#547608 , @ngraham wrote: > I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that? That pull request hasn't been merged yet, so all

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. I thought this change was introduced with 0.18.1 though? Aren't distros with an old SDDM using something older than that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt Cc:

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#547602 , @ngraham wrote: > FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

ngraham added a comment. FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we would rename the sessions upstream here. My preference would be to make the Wayland session say "Plasma (Wayland)" rather than renaming the X11 session ("Plasma on Xorg" sounds pretty

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D22210#498933 , @fvogt wrote: > In D22210#498929 , @asturmlechner wrote: > > > drop

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

pino added a comment. In D22210#498929 , @asturmlechner wrote: > drop translations No need to do that, scripty will take care of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To:

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#498929 , @asturmlechner wrote: > drop translations, rename to 'Plasma on Xorg' That would not be symmetric to "Plasma (Wayland)" though as produced by sddm. REPOSITORY R120 Plasma Workspace REVISION

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner updated this revision to Diff 62165. asturmlechner added a comment. drop translations, rename to 'Plasma on Xorg' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=60995=62165 BRANCH session-rename REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. I'll have to do this downstream, anyway... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. > This patch only helps with the case where SDDM is updated first, No, it solves all cases. Patched SDDM and therefore also GDM and LightDM show "Plasma (X11)" and "Plasma", while unpatched SDDM shows "Plasma (X11)" and "Plasma (Wayland)". REPOSITORY R120

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson added a comment. Yeah, I understand the situation. LightDM (when I worked on it at least) used to support the Icon property in the .desktop file. That'd be a quick and easy way to add an extra clarification on which one is wayland in the short term.

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. This is a necessary step to avoid having two indistinguishable "Plasma" options in SDDM with the linked PR merged and all other DMs , the other option is to have a "Plasma (Wayland) (Wayland)" in sddm only. AFAICT the translations for Name need to be removed

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with: - Plasma - Plasma (Wayland) Per linked issue it is not going to be like that forever; on every(?)

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This means most our normal users in an office who don't know/care if they're running X11 or wayland have some extra tech-garbage after the name. REPOSITORY R120

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it