D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#502044 , @broulik wrote: > Just checking, are you still up for making this kscreenlocker change? Given the heatwave right now I would have loved to be able to turn off my screens on the lock screen explic

D22261: Add a global shortcut action to turn off the screen

broulik added a comment. Just checking, are you still up for making this kscreenlocker change? Given the heatwave right now I would have loved to be able to turn off my screens on the lock screen explicitly :D REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D22261

D22261: Add a global shortcut action to turn off the screen

This revision was automatically updated to reflect the committed changes. Closed by commit R122:119943e6b883: Add a global shortcut action to turn off the screen (authored by mblumenstingl, committed by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#490680 , @broulik wrote: > Alright, very nice! > I suppose you don't have commit access, so I need an email address from you to add you as commit author. Thanks! I once had commit access but I'm

D22261: Add a global shortcut action to turn off the screen

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, very nice! I suppose you don't have commit access, so I need an email address from you to add you as commit author. Thanks! > I tried adding |Turn Off Screen to the powerde

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#490660 , @broulik wrote: > Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to whitelist this new action so that it also works on the lock screen. I tried adding `|Turn Off S

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added inline comments. INLINE COMMENTS > broulik wrote in powerdevildpmsaction.cpp:83 > I suppose there's no `Qt::Key_` enum for that, given laptops typically bypass > the operating system here anyway. I couldn't find any appropriate `Qt::Key_` so I'm leaving it up to the user to

D22261: Add a global shortcut action to turn off the screen

mblumenstingl updated this revision to Diff 61124. mblumenstingl marked 5 inline comments as done. mblumenstingl added a comment. updated patch to address the comments from @broulik REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22261?vs=61118&id=61124

D22261: Add a global shortcut action to turn off the screen

broulik added a comment. Thanks a lot for your patch! I have some minor style nitpicks (you probably just copied them from elsewhere but if we're adding new code, it should be tidy ;) Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to whitelist this new action s

D22261: Add a global shortcut action to turn off the screen

mblumenstingl created this revision. mblumenstingl added a reviewer: Plasma. mblumenstingl added a project: Plasma. Herald added a subscriber: plasma-devel. mblumenstingl requested review of this revision. REVISION SUMMARY PowerDevilDPMSAction already provides implementations for X11 and Wayland