D22316: Avoid garbling the sound if the volume slider is moved fast

This revision was automatically updated to reflect the committed changes. Closed by commit R115:a420dd6be1a9: Avoid garbling the sound if the volume slider is moved fast (authored by Kezi Olio keziolio...@gmail.com, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham added a comment. @davidedmundson and/or @drosca, are you good with this new approach? REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca, davidedmundson, ngraham Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel, kezik, LeGast00n,

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better! REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca, davidedmundson, ngraham Cc: anthonyfieroni, filipf, ngraham, davidedmundson, plasma-devel,

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 63008. kezik added a comment. I talked with 4-5 people and they all said that giving real time feedback in the slider is useless and bad, so here's that, the feedback is given on mouse release, and every problem is automatically solved. If you want

D22316: Avoid garbling the sound if the volume slider is moved fast

anthonyfieroni added a comment. updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198 REPOSITORY R115 Plasma Audio

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. In D22316#505466 , @ngraham wrote: > With this change, if I press the volume up and volume down key on my keyboard, feedback only plays every second or third time I hit the button (depending on how fast I press it).

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. With this change, if I press the volume up and volume down key on my keyboard, feedback only plays every second or third time I hit the button (depending on how fast I press

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 62863. kezik added a comment. > Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging? I made that it plays the sound at the final volume when you release the mouse button REPOSITORY R115 Plasma

D22316: Avoid garbling the sound if the volume slider is moved fast

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D22316: Avoid garbling the sound if the volume slider is moved fast

filipf added a comment. Ah I can definitely reproduce it. I agree, it sounds bad. +1 for fixing it. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #plasma, drosca Cc: filipf, ngraham, davidedmundson, plasma-devel, kezik,

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. In D22316#503998 , @filipf wrote: > Removed VDG as the reviewer, seems like a technical issue all together. Sorry > Also wanted to contribute, but I don't really perceive any issues when moving the slider fast

D22316: Avoid garbling the sound if the volume slider is moved fast

filipf added a comment. Removed VDG as the reviewer, seems like a technical issue all together. Also wanted to contribute, but I don't really perceive any issues when moving the slider fast :/ REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316

D22316: Avoid garbling the sound if the volume slider is moved fast

ngraham added a comment. In D22316#492059 , @kezik wrote: > I don't know why it is not showing the context of the patch 路‍♂️ > I selected the plasma-pa project Because you didn't use `arc` to submit the patch and Phabricator is kinda

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik updated this revision to Diff 61337. kezik added a comment. Thanks @davidedmundson for the feedback, I fixed what you suggested, but thinking about this again, the 50ms timer fixed the audio garbling but the sounds felt "too frequent", increasing the timer gave the same exact result

D22316: Avoid garbling the sound if the volume slider is moved fast

davidedmundson added inline comments. INLINE COMMENTS > volumefeedback.cpp:33 > + > +timer = new QTime(); > +timer->start(); This object leaks. You're better off just making it a member var directly. Also, see QElapsedTimer > volumefeedback.cpp:34 > +timer = new QTime(); > +

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. I don't know why it is not showing the context of the patch 路‍♂️ I selected the plasma-pa project REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #vdg Cc: plasma-devel, kezik, LeGast00n, jraleigh,

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik created this revision. kezik added a reviewer: VDG. kezik added a project: Plasma. Herald added a subscriber: plasma-devel. kezik requested review of this revision. REVISION SUMMARY I think that the audio should not be garbled if you move fast the audio slider (it distorts because it