D22514: Show if KRunner is still searching for more things

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fae4515f23fc: Show if KRunner is still searching for more things (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22514?vs=64655&id=64661#toc REPOSITORY R120 Plasma Workspa

D22514: Show if KRunner is still searching for more things

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I still think it should be more than 200ms, more like 500ms. INLINE COMMENTS > RunCommand.qml:103 > +opacity: !queryTimer.running && results.querying ? 1 : 0 > +

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64655. apol added a comment. simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64653&id=64655 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES lookan

D22514: Show if KRunner is still searching for more things

broulik added inline comments. INLINE COMMENTS > RunCommand.qml:105 > + > +opacity: queryTimer.stillQuerying ? 1 : 0 > +running: visible Easier would be `!queryTimer.running && results.querying`, then you don't need any of the custom state tracking And then just

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64653. apol added a comment. delay REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64265&id=64653 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES lookandfe

D22514: Show if KRunner is still searching for more things

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Can you please add the delay for when the spinner shows up. (And the opacity animation perhaps) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D22514: Show if KRunner is still searching for more things

ngraham accepted this revision as: VDG. ngraham added a comment. Then again, now that I'm trying that out, it might be kind of annoying, and it wouldn't show up well when using a dark theme. All right, let's go with this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phab

D22514: Show if KRunner is still searching for more things

ngraham added a comment. Never mind, I didn't have the whole stack built. This works well. I feel like I might prefer to have the spinner overlaid on top of the results view like @aspotashev suggested, inside a dark transparent rounded rectangle, maybe. That would visually connect the sp

D22514: Show if KRunner is still searching for more things

ngraham added a comment. Testing this out, the spinner never seems to go away, even after the results list has stopped changing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22514 To: apol, #plasma, #vdg Cc: mart, davidedmundson, ngraham, aspotashev, bro

D22514: Show if KRunner is still searching for more things

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in RunCommand.qml:86 > There was some code to make that magically work. > > (maybe it was that URLInterceptor we removed?) > > If it doesn't work, then just ignore me. > (maybe it was that URLInterceptor we removed?) yep :)

D22514: Show if KRunner is still searching for more things

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in RunCommand.qml:86 > There was some code to make that magically work. > > (maybe it was that URLInterceptor we removed?) > > If it doesn't work, then just ignore me. F7273406: Screenshot_20190823_121250.png

D22514: Show if KRunner is still searching for more things

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in RunCommand.qml:86 > Since it's using QQC2.TextField, won't it be using a completely different > colour scheme? There was some code to make that magically work. (maybe it was that URLInterceptor we removed?) If it doesn't wo

D22514: Show if KRunner is still searching for more things

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in RunCommand.qml:86 > Does using Kirigami.ActionTextField help with positioning? Since it's using QQC2.TextField, won't it be using a completely different colour scheme? REPOSITORY R120 Plasma Workspace REVISION DETAIL ht

D22514: Show if KRunner is still searching for more things

davidedmundson added a comment. Seems to work. There's some comments from Kai above. INLINE COMMENTS > RunCommand.qml:86 > +margins: units.smallSpacing > +rightMargin: height > +} Does using Kirigami.ActionTextField help with positionin

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64265. apol added a comment. positioning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64264&id=64265 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES loo

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64264. apol added a comment. Use the new querying property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=61925&id=64264 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AF

D22514: Show if KRunner is still searching for more things

ngraham added a comment. In D22514#512182 , @aspotashev wrote: > In D22514#502062 , @apol wrote: > > > Please review D22540 so I can offer a better solution for

D22514: Show if KRunner is still searching for more things

aspotashev added a comment. In D22514#502062 , @apol wrote: > Please review D22540 so I can offer a better solution for @broulik's concerns. You already fixed all of those, right? IMHO the busy in

D22514: Show if KRunner is still searching for more things

apol planned changes to this revision. apol added a comment. In D22514#502042 , @aspotashev wrote: > This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right? Yes, please review D22540 so I c

D22514: Show if KRunner is still searching for more things

aspotashev added a comment. This would fix https://bugs.kde.org/show_bug.cgi?id=409959 , right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22514 To: apol Cc: aspotashev, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zr

D22514: Show if KRunner is still searching for more things

broulik added a comment. Can you delay showing the busy indicator a bit? e.g. only show if there haven't been any new results for 500ms or so, to avoid that thing constantly flashing up. Perhaps easiest would be something like Timer { id: delayBusyIndicatorTimer interva

D22514: Show if KRunner is still searching for more things

broulik added a comment. This overlaps the clear button: F7045212: Screenshot_20190718_143324.png You might want to set some additional padding on the TextField and use acutal icon size: var actionIconSize = Math.max(control.height * 0.8, unit

D22514: Show if KRunner is still searching for more things

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Shows a busy indicator in the TextField. Depends on D22513 TEST PLAN Searched things, eventua