D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cullmann added a comment. Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure added a comment. Backported. https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel,

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. I'm not familiar with KDE release engineering, so I'm asking to do merging someone else. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #f

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

wbauer added a comment. What about the stable 5.16 branch? It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away... REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #fr

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:6d86fd453417: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with… (authored by arrowd). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kd

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, I'm wrong (not the first time this happens) :-) `kwrite /home/dfaure/.zshrc:20` works `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed. The patch looks fine

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#498393 , @dfaure wrote: > I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. > So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries h

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497556 , @cfeck wrote: > Oh, if the latter syntax also works, then you are right. Not sure what you mean by "also works". Current code checks if the URL ends with `:x:y` and turns it into `?line=x&column=

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cfeck added a comment. Oh, if the latter syntax also works, then you are right. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesj

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497332 , @cfeck wrote: > Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. I don't thin

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cfeck added a comment. Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd C

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY BUG: 408632 TEST PLAN `kioclient5 exec http://localhost:9000` now works correctly. REPOSITORY R126 KDE CLI Utilities BRANCH m