ngraham updated this revision to Diff 62313.
ngraham added a comment.
Make the scrollbar test work (thanks @mart)
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22564?vs=62116&id=62313
BRANCH
respect-scrollbar-visibility-for-swipelistitem (branched from
apol added a comment.
+1
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D22564
To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson,
mart, hein
ngraham updated this revision to Diff 62116.
ngraham marked an inline comment as done.
ngraham added a comment.
Remove unnecessary `!settings.isMobile` checks
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22564?vs=62068&id=62116
BRANCH
respect-scrollba
apol added inline comments.
INLINE COMMENTS
> SwipeListItem.qml:241
> verticalCenter: parent.verticalCenter
> -rightMargin: Units.gridUnit
> +rightMargin: !Settings.isMobile && behindItem.view &&
> behindItem.view.T2.ScrollBar && behindItem.view.T
ngraham created this revision.
ngraham added reviewers: mart, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now, `SwipeListItem` isn't as convergent as it could be. It always uses
a very
l
