This revision was automatically updated to reflect the committed changes.
Closed by commit R126:2eedaddd0e24: kstart: Prevent crash when running without
args (authored by tasossahanidis, committed by ngraham).
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
tasossahanidis marked an inline comment as done.
tasossahanidis added a comment.
Assuming I did everything correctly, it should be okay now.
REPOSITORY
R126 KDE CLI Utilities
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22613
To: tasossahanidis, davidedmundson
Cc: apol,
tasossahanidis updated this revision to Diff 62282.
tasossahanidis added a comment.
kstart: Use isEmpty()
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22613?vs=62196=62282
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22613
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> kstart.cpp:355
>} else {
> - if ( parser.positionalArguments().count() == 0 )
> + if ( parser.positionalArguments().count() == 0 ) {
>qCritical() << i18n("No command specified");
if (
tasossahanidis created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tasossahanidis requested review of this revision.
REVISION SUMMARY
Despite an error being thrown, kstart would continue, trying to
access an item that didn't exist in parser's
