D22627: Add a GUI option for choosing the input method

2019-07-23 Thread Nathaniel Graham
ngraham added a comment. In D22627#500454 , @filipf wrote: > Yeah an empty entry is bad UI but it works for the code since it ends up just grabbing the text from the combobox and writing it to the config file :P ... it was a quick solution I'll

D22627: Add a GUI option for choosing the input method

2019-07-22 Thread Filip Fila
filipf added a comment. Yeah an empty entry is bad UI but it works for the code since it ends up just grabbing the text from the combobox and writing it to the config file :P ... it was a quick solution I'll admit. The feature request was this, a much more straightforward idea: https://

D22627: Add a GUI option for choosing the input method

2019-07-22 Thread Nathaniel Graham
ngraham added a comment. In D22627#499798 , @filipf wrote: > In D22627#499699 , @ngraham wrote: > > > Also these hardcoded values make me feel a little leery. Is there a way we can programmatically

D22627: Add a GUI option for choosing the input method

2019-07-21 Thread Filip Fila
filipf added a comment. In D22627#499699 , @ngraham wrote: > Why is there a blank entry? The blank entry is sort of the whole point of the option. The way to fix the virtual keyboard popping up on its own with some themes is to leave Inpu

D22627: Add a GUI option for choosing the input method

2019-07-21 Thread Nathaniel Graham
ngraham added a comment. Why is there a blank entry? Also these hardcoded values make me feel a little leery. Is there a way we can programmatically generate them or get them from SDDM or something? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.o

D22627: Add a GUI option for choosing the input method

2019-07-21 Thread Filip Fila
filipf updated this revision to Diff 62233. filipf added a comment. combobox strings shouldn't be translatable REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22627?vs=62226&id=62233 BRANCH add-input-method-combobox (branched from m

D22627: Add a GUI option for choosing the input method

2019-07-21 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This exposes an existing SDDM InputMethod option and can function as a workaround for: https://github.com/sddm/sddm/issues/952 REPOS