D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev abandoned this revision. rgeorgiev added a comment. @broulik Hmm, now I think that I understood the rationale why SoundCloud support is activated using the **Enhanced Media Controls** option. As you commented on my other revision (D22632 ),

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-23 Thread Radoslav Georgiev
rgeorgiev planned changes to this revision. rgeorgiev added a comment. In D22631#499815 , @broulik wrote: > I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-22 Thread Kai Uwe Broulik
broulik added a comment. I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might want to enable "Enhanced Media Controls" in settings. REVISION DETAIL https://phabricator.kde.org/D22631 To: rgeorgiev Cc:

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-21 Thread Radoslav Georgiev
rgeorgiev updated this revision to Diff 62249. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22631?vs=62241=62249 REVISION DETAIL https://phabricator.kde.org/D22631 AFFECTED FILES extension/content-script.js To: rgeorgiev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

2019-07-21 Thread Radoslav Georgiev
rgeorgiev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rgeorgiev requested review of this revision. REVISION SUMMARY Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud