ngraham added inline comments.
INLINE COMMENTS
> GB_2 wrote in KNSBackend.cpp:214
> I think we can use the icon `plugins` here.
Submit a patch! :)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D22716
To: leinir, #discover_software_store, #vdg, ngraham
GB_2 added inline comments.
INLINE COMMENTS
> KNSBackend.cpp:214
> };
> -auto actualCategory = new Category(m_displayName,
> QStringLiteral("plasma"), filters, backendName, categories, QUrl(), true);
> +const auto iconName = knsrcPlasma.contains(fileName)?
> QStringLite
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:29fb6ce9e369: Add icons to Categories, Installed, and
Sources globaldrawer entries (authored by leinir).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Awesome! I've wanted this for a long time. LGTM. We can tweak the icons and
their assignments in subsequent patches if necessary.
REPOSITORY
R134 Discover Software Store
BRANCH
more-
leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.
REVISION SUMMARY
At some point, icons were removed from a number of entries in the global
drawer, but with the many other changes which have happened
