This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2de7c94402b0: [kcm-colors] Export colorscheme to GTK
color definitions (authored by cblack, committed by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
broulik accepted this revision.
broulik added a comment.
Good job!
REPOSITORY
R119 Plasma Desktop
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22844
To: cblack, #plasma, ngraham, broulik
Cc: ahiemstra, ngraham, davidre, broulik, plasma-deve
cblack updated this revision to Diff 63207.
cblack added a comment.
Fix the rebase shenanigans
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63196&id=63207
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricat
cblack updated this revision to Diff 63196.
cblack added a comment.
Rebasing shenanigans, pt 3.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63188&id=63196
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabrica
cblack updated this revision to Diff 63188.
cblack added a comment.
Rebase properly now?
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63187&id=63188
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricator.kde
cblack updated this revision to Diff 63187.
cblack added a comment.
Update to match master.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63185&id=63187
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricator.
cblack updated this revision to Diff 63185.
cblack added a comment.
Fix GtkColors flag
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63123&id=63185
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricator.kde.o
ahiemstra added a comment.
Just a small thing I noticed when scrolling through the patch.
INLINE COMMENTS
> krdb.h:31
> + KRdbExportGtkTheme= 0x0010, // Export KDE's widget style to Gtk if
> possible
> + KRdbExportGtkColors = 0x0012// Export KDE's colors to Gtk if
> possible
cblack updated this revision to Diff 63123.
cblack added a comment.
Add KRdbExportGtkColors flag to kcminit_style()
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63025&id=63123
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAI
broulik added a comment.
This doesn't apply the colors on startup, does it?
Probably needs the new flag passed in `kcminit_style`
REPOSITORY
R119 Plasma Desktop
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22844
To: cblack, #plasma, ngrah
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Thanks very much. This is excellent work, and I'm impressed. The feature
works perfectly and the code structure and implementation makes sense to me. I
think people are really going to lo
cblack updated this revision to Diff 63025.
cblack added a comment.
Deduplicate colors exporting code
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63010&id=63025
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://ph
ngraham added a comment.
Nice, it works every time now! I'm not super thrilled about all the code
duplication, though. Can't this live in just one place? If not here, then maybe
in plasma-framework?
INLINE COMMENTS
> .gitignore:1
> +.vscode
Unrelated to this patch; please remove from the d
cblack updated this revision to Diff 63010.
cblack added a comment.
Fix WM colors on first go round
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63009&id=63010
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://phab
cblack updated this revision to Diff 63009.
cblack added a comment.
Colors are now applied from the active colorscheme every time
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=63001&id=63009
BRANCH
kcm-colors-gtk (branched from master)
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Thanks, it works much better now. I'm really impressed with this, and it's
very cool to be able to see GTK3 apps respecting the system color scheme:
F7143222: Screenshot_201908
cblack updated this revision to Diff 63001.
cblack added a comment.
Make GTK colors its own KRDB flag
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22844?vs=62859&id=63001
BRANCH
kcm-colors-gtk (branched from master)
REVISION DETAIL
https://ph
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
Very cool idea. However I'm not seeing it work. No matter how many times I
change the color scheme, the .css files never get created. It doesn't work
after a reboot either.
REP
18 matches
Mail list logo
