victorr added a comment.
The “Apply” button stops working after the “Times” mode is activated.
Before turning on this mode, the rest works fine.
To fix, you can delete the line “Mode=Times" from the file
~/.config/kwinrc and restart the session.
https://bugs.kde.org/show_bug.cgi?id=4
zzag added inline comments.
INLINE COMMENTS
> filipf wrote in main.qml:118
> I think using the technical term here is fine. IIRC f.lux tried to simplify
> this by adding a bunch of descriptors which compared a particular temperature
> value or even range to a lighting condition, e.g. one genera
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5c0ec75f7ce1: [kcms/nightcolor] Minor UI tweaks to the
KCM (authored by filipf).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22863?vs=62875&id=62946
REVI
filipf added inline comments.
INLINE COMMENTS
> zzag wrote in main.qml:118
> There are some technical terms that should stay "technical," "color
> temperature" is one of those.
I think using the technical term here is fine. IIRC f.lux tried to simplify
this by adding a bunch of descriptors whi
zzag added inline comments.
INLINE COMMENTS
> ngraham wrote in main.qml:118
> "Night Color" is the name of the feature itself; you can't truncate it to
> save a few words. I think it also needs to keep its capitalization.
>
> If you're looking to change the string, I would focus on the word
>
ngraham added inline comments.
INLINE COMMENTS
> GB_2 wrote in main.qml:118
> Agreed.
"Night Color" is the name of the feature itself; you can't truncate it to save
a few words. I think it also needs to keep its capitalization.
If you're looking to change the string, I would focus on the word
GB_2 added inline comments.
INLINE COMMENTS
> zzag wrote in main.qml:118
> but it depends on how you look at it. "Night color temperature" might be a
> better string. As it speaks about color temperature and not temperature of
> "Night Color."
Agreed.
REPOSITORY
R119 Plasma Desktop
BRANCH
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in main.qml:118
> Just my 2 cents: you can simplify this string to "Night temperature." Not
> sure whether translators will like this change though.
but it depends on how you look at it. "Night color temperature" might be a
better string
zzag added inline comments.
INLINE COMMENTS
> romangg wrote in main.qml:118
> I would leave it with the capital C since it's part of the name.
Just my 2 cents: you can simplify this string to "Night temperature." Not sure
whether translators will like this change though.
REPOSITORY
R119 Plas
romangg added inline comments.
INLINE COMMENTS
> filipf wrote in main.qml:118
> @romangg you wrote the feature, should we capitalize its name? :)
I would leave it with the capital C since it's part of the name.
REPOSITORY
R119 Plasma Desktop
BRANCH
nightcolor-kcm-tweaks (branched from mast
filipf added a subscriber: romangg.
filipf added inline comments.
INLINE COMMENTS
> GB_2 wrote in main.qml:118
> Lowercase c?
@romangg you wrote the feature, should we capitalize its name? :)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D22863
To: filipf, #pl
GB_2 added inline comments.
INLINE COMMENTS
> main.qml:118
> +RowLayout {
> Kirigami.FormData.label: i18n("Night Color temperature:")
> enabled: activator.checked
Lowercase c?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.k
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.
REVISION SUMMARY
- the slider is now of the same width as the comobox below it
- the slider's value has been placed to the right of the slider, as th
13 matches
Mail list logo
