D22874: Remove the ShellManager

2019-08-05 Thread Kai Uwe Broulik
broulik added a comment. I can repdroduce plasmashell crashing. The `--replace` option is fine but it just crashes on teardown. Thread 1 "plasmashell" received signal SIGSEGV, Segmentation fault. 0x71fafd66 in QScopedPointer >::operator-> (this=) at ../../include/QtC

D22874: Remove the ShellManager

2019-08-05 Thread Noah Davis
ndavis added a comment. In D22874#506843 , @broulik wrote: > I get the `plasmashell --replace` not working correctly occasionally. I don't think this is related to any of this. I'm pretty sure it is. I can reliably reproduce tge bug with

D22874: Remove the ShellManager

2019-08-05 Thread Kai Uwe Broulik
broulik added a comment. I get the `plasmashell --replace` not working correctly occasionally. I don't think this is related to any of this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22874 To: apol, #plasma, davidedmundson, bshah Cc: broulik, ndavis,

D22874: Remove the ShellManager

2019-08-05 Thread Noah Davis
ndavis added a comment. After this patch, when I run `plasmashell --replace &` 3 times in a row, the following happens: 1st time: Plasmashell runs F7165069: 1.txt 2nd time: Plasmashell segfaults with `"No such object path '/org/kde/plasmashe

D22874: Remove the ShellManager

2019-08-01 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d754abbc4799: Remove the ShellManager (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22874?vs=62898&id=62957 REVISION DETAIL https://

D22874: Remove the ShellManager

2019-08-01 Thread Bhushan Shah
bshah accepted this revision. bshah added a comment. Please also remove loader.qml from shell packages I guess. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22874 To: apol, #plasma, davidedmundson, bshah Cc: bshah, davidedmundson, plasma-

D22874: Remove the ShellManager

2019-08-01 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. The desktop loader has been broken since before 5.0, I think it's a classic example of building something too early. We can always revert if we find a usage later. Go fo

D22874: Remove the ShellManager

2019-08-01 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We had an overly complex and in practice unexploited system to detect which shell to use, This patch ch