D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-12 Thread Björn Feber
GB_2 updated this revision to Diff 63611. GB_2 added a comment. Use a QMenu REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63460=63611 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a comment. In D22896#509989 , @ngraham wrote: > Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. Yeah, we that feature is also not

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Marco Martin
mart accepted this revision. mart added a comment. Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any moment in any future release REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 updated this revision to Diff 63460. GB_2 added a comment. "Configure" -> "Configure..." REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63458=63460 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a subscriber: mart. GB_2 added a comment. Ping @mart, can you please help here? REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2,