D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mgallien added a comment. This patch breaks compatibility with Qt5.11 where Qt Quick Controls2 is in version 2.4. I noticed it after Debian upgraded the package and I am unable to let Elisa run with it. I will try to work on a fix. REPOSITORY R169 Kirigami REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fd8fec5b8923: Allow usage of QQC2 actions on Kirigami components and now make K.Action based… (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63727. camiloh added a comment. clean up code, remove comments and documentation fixes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63726=63727 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart added inline comments. INLINE COMMENTS > Action.qml:27 > * > * @inherit QtObject > */ @inherit QtQuick.Controls.Action > Action.qml:76 > */ > -property ActionIconGroup icon: ActionIconGroup { > -id: iconGroup > -} > +// property ActionIconGroup icon:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63726. camiloh added a comment. remove debugging line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63725=63726 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added a comment. In D22974#508067 , @mart wrote: > good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group The solution here was to add back the

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63725. camiloh added a comment. fallback to custom kirigamiAction property for PrivateActionToolButton - useage of the fallback property due to: if we use QQC2.ToolButton default action property then the style will draw the content, and since this

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group INLINE COMMENTS > camiloh wrote in Action.qml:76 >

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63242. camiloh added a comment. remove todo line REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63241=63242 BRANCH k-action-to-qqc2-action (branched from master) REVISION DETAIL

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63241. camiloh added a comment. Correct possible undefined result pointed out by Aleix REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22974?vs=63240=63241 BRANCH k-action-to-qqc2-action (branched from master)

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh added inline comments. INLINE COMMENTS > camiloh wrote in ActionToolBar.qml:184 > I think it then gets marked as visible = true You were right, I have now fixed it. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22974 To: camiloh, #kirigami, mart Cc:

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh updated this revision to Diff 63240. camiloh marked an inline comment as done. camiloh added a comment. further changes to make components work with new Kirigami.Action based on QQC2.Action, and proposed solution to draw the PrivateActionToolButton REPOSITORY R169 Kirigami CHANGES

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh marked 2 inline comments as done. camiloh added a comment. I have worked on the duplicating icons, by not using the contentItem to draw the icons and label, and instead use the style implementation. The only thing missing would be the dropdown icon for actions with submenus, I'm

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

apol added a comment. WRT the two icons, maybe it would make sense to populate only the bits we want instead of using the action property? i.e. we can keep a kirigamiAction property for now. This patch is far too big as is already. I would even suggest doing the Kirigami.Action rebase first

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

camiloh created this revision. camiloh added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY The ideal is to be able to add regular qqc2 actions to the actiontoolbar, pageheaders,