D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R115:faef1e8f152e: Allow to set maximum volume < 100% (authored by kishoreg, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D230

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. Thanks for the vid. Also I feel betrayed now by my system. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23082 To: kishoreg, #plasma, drosca, ngraham, romangg Cc: romangg, ngraham, plasma-d

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
ngraham added a comment. In D23082#510628 , @romangg wrote: > When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though. Works for me FWIW: F7205124: Works f

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Roman Gilg
romangg added a comment. When you're at it could you take a look at why hardware keys are not working above 100%? Shouldn't be handled with a separate patch though. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23082 To: kishoreg, #plasma, drosc

D23082: Allow to set maximum volume < 100%

2019-08-11 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. I could see this being useful if your hardware had super loud speakers, or if you were deliberately trying to reduce the noisiness of your environment. REPOSITORY R115 Plasma Audi

D23082: Allow to set maximum volume < 100%

2019-08-10 Thread Kishore Gopalakrishnan
kishoreg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Currently one cannot set the maximum volume < 100%. This feature is required because some earphones / speakers are more sensitive