D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66922. ngraham added a comment. Squash changes from D24251 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=66916=66922 BRANCH improve-kickoff-settings-button-grid

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66916. ngraham added a comment. Rebase again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=66915=66916 BRANCH improve-kickoff-settings-button-grid (branched from master) REVISION DETAIL

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66915. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=63756=66915 BRANCH improve-kickoff-settings-button-grid (branched from master) REVISION DETAIL

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. @davidedmundson this missed 5.17. I could still use a hand with the changes you requested to land this in 5.18. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein Cc: hein,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. @davidedmundson ping. I fixed one issue but may need a bit of help for the one about the weird sizing for the button grid component. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. Visually +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 63756. ngraham added a comment. Use Layout.preferred[Width|Height] REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=63748=63756 BRANCH improve-kickoff-settings-button-grid (branched from master)

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigGeneral.qml:124 > What's this about? It's typically a sign that something else is wrong. > > Probably the lack of spacer in this dialog means the label below occupies >

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Intention makes sense, as do most the changes. Just some minor comments. INLINE COMMENTS > ConfigGeneral.qml:124 > +Layout.topMargin: units.gridUnit > +

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The button grid was not centered, the content inside the buttons was not centered, the