D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. In D23174#519704 , @ngraham wrote: > Hooray! > > Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? Unfortunately, I don't know the code base

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. Hooray! Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham, #kacti

D23174: Improve the look of the Activities KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbd0465c3b1c: Improve the look of the Activities KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63818&id=64686 REVISION

D23174: Improve the look of the Activities KCM UI

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma, LeG

D23174: Improve the look of the Activities KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63818. GB_2 added a comment. Fix "blocked" emblem icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63817&id=63818 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://ph

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63817. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63800&id=63817 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. Very nice work. This is close to a "shipit" already IMO from my perspective. I just have a few more comments: INLINE COMMENTS > GeneralTab.qml:26 > +import org.kde.kquickcontrols 2.0 as KQuickControls > +import org.kde.kquickcontrolsaddons 2.0 as KQuickControls >

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. As a further improvement, I might even merge the contents of the "Switching" tab into the main "Activities" tab. There's room below the Activities list because typically people are going to have 1-4 activities at most; it's not generally going to be a huge tall list

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63800. GB_2 added a comment. "Only for specific applications" -> "Only for specific applications:" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63793&id=63800 BRANCH improved-activities-kcm-ui (branche

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. UI is super better now, wow. INLINE COMMENTS > PrivacyTabBase.ui:60 > + > +O&nly for specific applications > + I'd add a colon after this (`Only for specific applications:`) because the grid of specific applications is right after it. REPOSITO

D23174: Improve the look of the Activities KCM UI

GB_2 updated this revision to Diff 63793. GB_2 added a comment. Remove unneeded import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63792&id=63793 BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabr

D23174: Improve the look of the Activities KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, port to QQC2 and Kirigami, make the KCM look better and make the KCM show up in sea