D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

This revision was automatically updated to reflect the committed changes. Closed by commit R128:52ea204e39d5: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach… (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64420. meven added a comment. Rebase REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64402=64420 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED FILES

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R128 User Manager BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2 Cc: nicolasfella, GB_2, plasma-devel, LeGast00n,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven added a comment. In D23337#516758 , @ngraham wrote: > The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64402. meven added a comment. Change the change password button text to Set Password for new users REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64279=64402 BRANCH arcpatch-D23337 REVISION DETAIL

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

ngraham added a subscriber: nicolasfella. ngraham added a comment. The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64279. meven added a comment. Fix tab order REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64278=64279 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED FILES

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64278. meven added a comment. Replace Q_FOREACH by for REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64276=64278 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64276. meven added a comment. Add a const before a for REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64275=64276 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven updated this revision to Diff 64275. meven added a comment. Add icon document-edit REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64274=64275 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

GB_2 added inline comments. INLINE COMMENTS > account.ui:227 > > - > - > - > - 0 > - 0 > - > - > + > Add the icon `document-edit` REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven added a comment. This is not yet "great" but makes things more usable. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D23337 To: meven, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven added a comment. The issue was highlighted in https://youtu.be/Fl7TWroe2Zw?t=709 REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D23337 To: meven, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The current behavior to change password is quite unfriendly to say the least. Clicking in a line