D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in main.qml:27 > Is this actually used? Also, because it's not installed by default it shows > an error. Fixed in https://commits.kde.org/plasma-desktop/659a46aac39789c40e8cd07060e3bacd5fe8d461 REPOSITORY R119 Plasma Desktop

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added inline comments. INLINE COMMENTS > main.qml:27 > +import org.kde.kcm 1.1 as KCM > +import Qt.labs.platform 1.1 > + Is this actually used? Also, because it's not installed by default it shows an error. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67572=67701

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Would be nice to fix some of these bugs in follow-up patches too: https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1669138=systemsettings=--- REPOSITORY R119 Plasma

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67572. tcanabrava added a comment. - Fix Strings - Fix margins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67568=67572 BRANCH kcm_baloo_qml REVISION DETAIL

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. Almost done, just a tiny bit of polish is needed! See inline comments: INLINE COMMENTS > kcm.cpp:61 > KAboutData* about = new KAboutData( > QStringLiteral("kcm_baloofile"), i18n("Configure File Search"), > QStringLiteral("0.1"), QString(),

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava marked 2 inline comments as done. tcanabrava added a comment. I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67568. tcanabrava added a comment. - fix Comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67567=67568 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67567. tcanabrava marked 7 inline comments as done. tcanabrava added a comment. - Simplify Checkboxes - Fix previouslyEnabled logic - Tell Qml that we have the values - Move code around - Fix QSet math - Qml gives us a Url, we want the Local

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. See inline comments. Also functionality-wise there are some problems: 1. When a new entry is added, if the KCM is closed and re-opened, the new entry has been

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67563. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added a comment. Relevant: https://bugs.kde.org/show_bug.cgi?id=351647 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava added a comment. got it, updating. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

GB_2 added a comment. In D23718#536359 , @ngraham wrote: > The frame's alignment and padding seem off: F7416705: Screenshot_20190923_075306.png > > Could we use a list more like the one used in the

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. The frame's alignment and padding seem off: F7416705: Screenshot_20190923_075306.png Could we use a list more like the one used in the Virtual Desktops KCM and the slideshow wallpaper folder list? Then we would have a

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

nicolasfella added inline comments. INLINE COMMENTS > metadata.desktop:3 > +Name=Search > +Comment=Choose color scheme > + That comment sounds wrong :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc:

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66643. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This isn't ready yet without, at a minimum, the UI change I requested for the list view. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. FWIW, it would be good to fix some of the bugs listed here as part of the port: https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1663634=systemsettings=--- REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. Getting there! Use an actual framed list view for the list of folders to not index, like the current one has. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma Cc: mart, ngraham, plasma-devel,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66258. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button REPOSITORY

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65378. tcanabrava added a comment. - Name fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65375=65378 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65375. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65369=65375 BRANCH kcm_baloo_qml

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > main.qml:31 > + > +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the > search in the system.") > + While we're at it, let's improve this string: "This module lets you configure the system-wide file search features"

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added a comment. please, include screenshots REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added inline comments. INLINE COMMENTS > main.qml:33 > + > +QtControls.Label { > +text: i18n("File Search helps you quickly locate all your files > based on their content") should use a Kirigami.FormLayout to have checkboxes centered? REPOSITORY R119 Plasma Desktop

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > main.qml:23 > +import QtQuick.Layouts 1.1 > +import QtQuick.Controls 2.0 as QtControls > +import QtQuick.Dialogs 1.2 as QtDialogs `import QtQuick.Controls 2.5 as QQC2` (See T10862 ) REPOSITORY R119 Plasma

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED FILES