D23798: Polish KCM UI

ngraham added inline comments. INLINE COMMENTS > main.qml:123 > outputs: kcm.outputModel > +// visible: kcm.numberOfOutputs > 1 // FIXME: this is -1 here; > does it get set too late? > } And I could use some help with the issue detailed in the comment here. RE

D23798: Polish KCM UI

ngraham updated this revision to Diff 65687. ngraham added a comment. Remove unnecessarily-added id for main layout REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65685&id=65687 BRANCH clean-up-ui (branched from master) REVISION DETAIL https:

D23798: Polish KCM UI

ngraham updated this revision to Diff 65685. ngraham added a comment. Use same slider style for the per-output Wayland version REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65684&id=65685 BRANCH clean-up-ui (branched from master) REVISION DETA

D23798: Polish KCM UI

ngraham updated this revision to Diff 65684. ngraham added a comment. ...And also capitalize correctly REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65683&id=65684 BRANCH clean-up-ui (branched from master) REVISION DETAIL https://phabricator

D23798: Polish KCM UI

ngraham updated this revision to Diff 65683. ngraham marked 2 inline comments as done. ngraham added a comment. Add icons to pushbuttons REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65674&id=65683 BRANCH clean-up-ui (branched from master) REV

D23798: Polish KCM UI

ngraham added a comment. In D23798#527978 , @ndavis wrote: > What are "Values of an output"? I don't understand what these 2 settings do. I agree that this part is rather confusing. @romangg can confirm, but as far as I understand it,

D23798: Polish KCM UI

filipf added a comment. In D23798#527978 , @ndavis wrote: > What are "Values of an output"? I don't understand what these 2 settings do. +1 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, roma

D23798: Polish KCM UI

ndavis added a comment. What are "Values of an output"? I don't understand what these 2 settings do. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D23798: Polish KCM UI

GB_2 added a comment. +1 INLINE COMMENTS > Screen.qml:65 > onClicked: kcm.identifyOutputs() > text: i18n("Identify") > focusPolicy: Qt.NoFocus Icon: "documentinfo" > Screen.qml:71 > onClicked: resetTotalSize() > text: i18n("Ce

D23798: Polish KCM UI

ngraham added a comment. I was not 100% sure about the method I chose to get the number of outputs, so I would appreciate if #kwin folks could me know if this is wrong or there's a better way. REPOSITORY R104 KScreen REVISION DETAIL https://phabri

D23798: Polish KCM UI

ngraham created this revision. ngraham added reviewers: romangg, VDG, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves and polishes the new KScreen KCM's UI in a variety of ways. A pict