D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

This revision was automatically updated to reflect the committed changes. Closed by commit R119:21d962fe33c8: [kfontinst] Port to use icons from the icon theme and make HiDPI aware (authored by Guo Yunhe ). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://ph

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Fere

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66229. guoyunhe added a comment. Rename and move the find duplicate button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66193&id=66229 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham added a comment. Rename Scan Duplicates... to Find Duplicates... and move the button to the left of Install from File... and then I think this will be good. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngrah

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66193. guoyunhe added a comment. Fix size policy REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66191&id=66193 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 AFFECTED FILES kc

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66191. guoyunhe added a comment. Avoid scrollbar. Put progressbar and font status to another row. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66157&id=66191 BRANCH master REVISION DETAIL https:

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Uh-oh, moving the button down to the lower row now causes the layout to get so wide with English that it overflows the default System Settings window size: F7357577: Screenshot_

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66157. guoyunhe added a comment. Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66101&id=66157 BRANCH

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham added a comment. In D23868#532065 , @guoyunhe wrote: > Now I can get something like this (the QLineEdit and QPushButton still have different height): > > F7357403: image.png That's better

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. Now I can get something like this (the QLineEdit and QPushButton still have different height): F7357403: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasm

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham added a comment. In D23868#532046 , @guoyunhe wrote: > In D23868#532016 , @ngraham wrote: > > > Maybe in the interests of #consistency , let's m

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. In D23868#532016 , @ngraham wrote: > Maybe in the interests of #consistency , let's make the filter feature look the same way that it does in the Colors KCM: F7357040: Scre

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham added a comment. Maybe in the interests of #consistency , let's make the filter feature look the same way that it does in the Colors KCM: F7357040: Screenshot_20190915_131425.png REPOSITORY R119 P

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66101. guoyunhe added a comment. Unify button look REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66074&id=66101 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 AFFECTED FILES

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe added a comment. I changed it to QToolButton, but it still look different: F7352361: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel,

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Either use a ToolButton for the filter feature, or turn "Scan for duplicate fonts" into a PushButton, so they match one way or another. REPOSITORY R119 Plasma Desktop REVISIO