D23876: [applets/kickoff] Tweak padding for lists

2019-12-14 Thread Filip Fila
filipf abandoned this revision. filipf added a comment. Don't want to go through with this anymore because I've had a look at other views and they always sharply cut off content horizontally. For example: F7818671: image.png REPOSITORY R119 Plasma

D23876: [applets/kickoff] Tweak padding for lists

2019-12-14 Thread Nathaniel Graham
ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23876 To: filipf, #vdg, #plasma, ngraham Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, leslie

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Filip Fila
filipf planned changes to this revision. filipf added a comment. In D23876#529485 , @ngraham wrote: > Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Nathaniel Graham
ngraham added a comment. I'm talking about the margins outside the selection highlight effect, which should be equal on the bottom as on the sides. I hadn't even noticed the difference in margins within the selection highlight lol (and yes, I do use non-default fonts and sizes: 11pt Ubuntu f

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Noah Davis
ndavis added a comment. In D23876#529485 , @ngraham wrote: > Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png Are you talking about t

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Noah Davis
ndavis added a comment. > F7340957: Screenshot_20190911_163422.png > F7340963: Screenshot_20190911_163617.png Look at the top of the view in both screenshots and bottom of the view in the 2nd. Rather than c

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Nathaniel Graham
ngraham added a comment. Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23876 To: filipf, #vdg, #plasma,

D23876: [applets/kickoff] Tweak padding for lists

2019-09-11 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Add padding on top and at the bottom of lists in Kickoff so the highlight effect doesn't overlap the separator. REPOSITORY R119 Pl