D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-17 Thread David Edmundson
davidedmundson added a comment. But I could still just copy the relevant lines into kcmshell directly instead of linking. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, Orage,

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-17 Thread David Edmundson
davidedmundson added a comment. > Any update here? Can this hack be dropped now? I did follow up on that. A distro is still wanting to do the setup which requires this opt-in hack. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker,

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-16 Thread Andreas Sturmlechner
asturmlechner added a comment. In D23883#530551 , @davidedmundson wrote: > It only exists as a hack around some Qt5.9(?) bug to allow plasma stuff to be in wayland without needing us to force an environment variable. > Personally I want to ki

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-13 Thread David Edmundson
davidedmundson added a comment. You split the source out? I see. Lets sort out the stupid kworkspace dependency on kde-cli-tools upstream rather than have you guys doing horrible things. It's caused issues elsewhere. It only exists as a hack around some Qt5.9(?) bug to allow plasma s

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. In D23883#529898 , @davidedmundson wrote: > Happy to help, but I don't understand yet. > > kde-cli-tools doesn't use sessionmanagementbackend.h? > > The only user is inside plasma-workspace source. I o

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread David Edmundson
davidedmundson added a comment. Happy to help, but I don't understand yet. kde-cli-tools doesn't use sessionmanagementbackend.h? The only user is inside plasma-workspace source. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker,

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Andreas Sturmlechner
asturmlechner added a comment. copy that for Gentoo. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Heiko Becker
heikobecker added a comment. Admittedly to solve a problem, which originates from our downstream packaging. kde-cli-tools is a dependency of some applications and frameworks, which might be interesting to non Plasma users but depends on libkworkspace. As a a source based distro we cannot eas

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-11 Thread David Edmundson
davidedmundson added a comment. From my header: /** - Performs direct system actions that could kill the session * - Semi-internal. Symbols exported, but not the header - To be used only by the daemon that performs logout (currently ksmserver) * - All other users should go via t

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-11 Thread David Edmundson
davidedmundson added a comment. what for? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, him

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-11 Thread Heiko Becker
heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN header gets installed, plasma-workspace builds fine against a previously and separately built libkworkspace REPOSITORY R120 Pl