D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66251. tienisto added a comment. use Kirigami units for vertical margin REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66250&id=66251 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:28 > color: Kirigami.Theme.backgroundColor > +property int verticalMargin: 50 > How about `Kirigami.Units.gridUnit * 3` instead? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kd

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66250. tienisto added a comment. change "Frequently used:" to "Frequently Used" REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66246&id=66250 BRANCH master REVISION DETAIL https://phabricator.kde

D23984: [System Settings] redesign intro page

GB_2 added inline comments. INLINE COMMENTS > introPage.qml:92 > wrapMode: Text.NoWrap > text: i18n("Frequently used:") > } Maybe change to "Frequently Used", so it's a header? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabr

D23984: [System Settings] redesign intro page

tienisto added a comment. What do other people think about the light rectangle around the "frequently used" icons? Because I am in favor of this :) REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc:

D23984: [System Settings] redesign intro page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. Everyone else fine with this? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf,

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66246. tienisto added a comment. use rounding again and delete unused id REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66245&id=66246 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:85 > } > -width: Math.round(parent.width * 0.8) > +width: parent.width * 0.8 > + Why change this? Rounding generally fixes the problem of blurriness with fractional scaling due to non-integer pixels. > intr

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66245. tienisto added a comment. move Kirigami.Heading inside ColumnLayout REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66244&id=66245 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D23984: [System Settings] redesign intro page

ngraham added a comment. TBH I kind of liked the rectangle too. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev, cbl

D23984: [System Settings] redesign intro page

tienisto added a comment. In D23984#532719 , @GB_2 wrote: > What about a design like this? F7363944: System Settings Intro Page Mockup.png I actually like the light rectangle more because it increase

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:78 > } > -Kirigami.Separator { > -id: separator > -anchors.centerIn: parent > -width: Math.round(parent.width * 0.8) > +Kirigami.Heading { > +id: frequentlyUsed Why move this heading out o

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66244. tienisto added a comment. Remove light rectangle; add Plasma icon; more Kirigami units REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66205&id=66244 BRANCH master REVISION DETAIL https://p

D23984: [System Settings] redesign intro page

GB_2 added a comment. As you can see in my design, I'd not add a rectangle in the backround, it looks weird to me and less clean than before. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23984: [System Settings] redesign intro page

ngraham added a comment. Always good to add the plasma logo in more Plasma places, so I do like that part. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, pla

D23984: [System Settings] redesign intro page

GB_2 added a comment. What about a design like this? F7363944: System Settings Intro Page Mockup.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni, da

D23984: [System Settings] redesign intro page

ngraham added a comment. +1, nice visual improvement. Needs a bit of code polishing first before it can land though. See inline comments: INLINE COMMENTS > introPage.qml:31 > +property int iconsRectRadius: 10 > > signal focusNextRequest() Don't hardcode values here; instead use m

D23984: [System Settings] redesign intro page

tienisto marked 4 inline comments as done. tienisto added a comment. Okay. Now I am using more Kirigami units now. About "KDE Plasma" vs "Plasma" I am not sure because Plasma is less known than KDE. Regarding the round corners, I have decreased the radius a little bit. Hope it is better now

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66205. tienisto added a comment. less rounded corners and decrease use of hard coded numbers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66201&id=66205 BRANCH master REVISION DETAIL https://ph

D23984: [System Settings] redesign intro page

filipf added a comment. +1 for redesigning the page a bit. What I really dislike about it right now is that there is no hover effect for the icons. Regarding the changes here, I'm unsure about the rounded rectangle. Doesn't seem like it fits with design everywhere else. Will comment

D23984: [System Settings] redesign intro page

tienisto marked 3 inline comments as done. tienisto added a comment. Thanks for your feedback. I was actually lighten the background instead of darken it :) But still, Qt.darker/Qt.lighter is much simpler! REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D239

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66201. tienisto added a comment. simplify brighter background REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66192&id=66201 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23984 AFFEC

D23984: [System Settings] redesign intro page

mart added a comment. overall to me looks a bit less balanced, but if VDG as a whole says it's ok, i'm fine with it. however there are some small things in the code to fix INLINE COMMENTS > davidedmundson wrote in introPage.qml:65 > Hardcoding sizes is generally frowned upon. > > Partly bec

D23984: [System Settings] redesign intro page

anthonyfieroni added inline comments. INLINE COMMENTS > introPage.qml:60 > +Kirigami.Heading { > +text: "KDE Plasma" > +font.pointSize: 24 // largest level is too small, so we use > pointSize Use i18n also only Plasma about me. > introPage.qml:61 > +

D23984: [System Settings] redesign intro page

davidedmundson added inline comments. INLINE COMMENTS > introPage.qml:65 > +text: i18n("System Settings") > +font.pointSize: 16 > +} Hardcoding sizes is generally frowned upon. Partly because things are user-configurable, partly because if every dev

D23984: [System Settings] redesign intro page

mart added inline comments. INLINE COMMENTS > introPage.qml:82 > +Rectangle { > +property real brightness: (0.2126*Kirigami.Theme.backgroundColor.r + > 0.7152*Kirigami.Theme.backgroundColor.g + > 0.0722*Kirigami.Theme.backgroundColor.b) > +anchors { add in a comment a link

D23984: [System Settings] redesign intro page

Codezela added a comment. What about removing the big settings icon And make 2 row of recently used center them vertically and horizontally Or put some tooltips or shortcuts guided instead REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tieni