D24036: Fix the last fix of the max y-range computation

This revision was automatically updated to reflect the committed changes. Closed by commit R102:c177c39ef878: Fix the last fix of the max y-range computation (authored by alexde, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?v

D24036: Fix the last fix of the max y-range computation

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. You good now? REPOSITORY R102 KInfoCenter BRANCH ymax_again (branched from master) REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg, ngraham Cc: plasma-devel, L

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66344. alexde added a comment. The next loop starts with index+1. This rare case with index out of bounds should not happen, but just in case ... REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66343&id=6634

D24036: Fix the last fix of the max y-range computation

alexde added a comment. This range check should definitely be included. The other error, I don't know right away. If no one else spots it, I will check it on the weekend. Regards REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D24036 To: alexde, #vdg, ngraha

D24036: Fix the last fix of the max y-range computation

alexde updated this revision to Diff 66343. alexde added a comment. Add range check for index variable REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24036?vs=66340&id=66343 BRANCH ymax_again (branched from master) REVISION DETAIL https://phabrica

D24036: Fix the last fix of the max y-range computation

alexde added a comment. In D24036#533557 , @ngraham wrote: > I still get: > > file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined > file:///home/nate

D24036: Fix the last fix of the max y-range computation

ngraham added a comment. I still get: file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot read property 'x' of undefined file:///home/nate/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/Graph.qml:114: TypeError: Cannot

D24036: Fix the last fix of the max y-range computation

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The last fixed was not correct. This version should serve better. REPOSITORY R102 KInfoCenter