This revision was automatically updated to reflect the committed changes.
Closed by commit R124:559444be5f2e: add tooltips to the intro page (authored by
tienisto, committed by ngraham).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
tienisto updated this revision to Diff 66387.
tienisto added a comment.
using enums (ToolTipPosition) instead of booleans
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24049?vs=66376=66387
BRANCH
intropage-tooltips (branched from master)
tienisto added inline comments.
INLINE COMMENTS
> ngraham wrote in SidebarMode.cpp:581
> Is there a strong reason to move these around?
I want to have all the initializations of tooltip managers in one place. I
couldn't add the third manager there because the placeHolderWidget is not
ngraham added a comment.
In general +1
INLINE COMMENTS
> SidebarMode.cpp:581
>
> +d->toolTipManager = new ToolTipManager(d->searchModel, d->quickWidget,
> false);
> +d->subCategoryToolTipManager = new ToolTipManager(d->subCategoryModel,
> d->quickWidget, false);
Is there a
tienisto updated this revision to Diff 66376.
tienisto added a comment.
remove unnecessary brackets in onEntered and onExited
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24049?vs=66374=66376
BRANCH
intropage-tooltips (branched from master)
tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tienisto requested review of this revision.
REVISION SUMMARY
Add tooltips to the most used settings in the intro page
TEST PLAN
Move your cursor on one of
