D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

This revision was automatically updated to reflect the committed changes. Closed by commit R99:d3060530e8f8: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists (authored by heikobecker). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

heikobecker updated this revision to Diff 66496. heikobecker added a comment. Used the ReadWrite flag to simplify REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24087?vs=66473&id=66496 BRANCH Plasma/5.17 REVISION DETAIL https://phabr

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

gikari added inline comments. INLINE COMMENTS > appearancegtk2.cpp:96 > + > if (gtkrc.open(QIODevice::ReadOnly | QIODevice::Text)) { > QString fileContents{gtkrc.readAll()}; I think file creation could be simplified. Just replace WriteOnly flag with ReadWrite here. This would mean

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM but let's see what @apol thinks. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24087 To: heikobecker, gikari, #pla

D24087: Create an empty config (.e.g ~/.gtkrc-2.0) if none exists

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY After a9f3a3d saveSettingsPrivate() errors out