D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma updated this revision to Diff 66913. maximma added a comment. Bug Fix 410988 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24146?vs=66694=66913 BRANCH calculatorApplet (branched from master) REVISION DETAIL

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. ok REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed,

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. Change the files to remove those changes using your text editor, then run `arc diff`. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. ok, how remove changes from those path? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. If there are three changes necessary (fix display, fix bug, change C behavior) then we need three patches in a dependency chain. :) See https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project REPOSITORY R114 Plasma Addons

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. In D24146#538295 , @ngraham wrote: > Make a second patch that only fixes the bug, and then remove those changes from this patch. Do I need to create another page with only bug fix? Or do I need to make another

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. Make a second patch that only fixes the bug, and then remove those changes from this patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. In D24146#538292 , @ngraham wrote: > In D24146#538284 , @maximma wrote: > > > > > > Excellent. Could you split this out so we have two patches: Yes, could you

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. In D24146#538284 , @maximma wrote: > 1. I am not sure where the description window is. You can click on the Edit Revision button to add stuff to the description. > 2. Yes, this fixes this bug. I am not sure

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. 1. I am not sure where the description window is. 2. Yes, this fixes this bug. I am not sure how much this is the right solution, because I am not familiar with js at a sufficient level. But having considered all the solutions, I realized that this is one of the

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added reviewers: Plasma, cfeck. ngraham added a comment. 1. This needs more explanation in the Description section to indicate why the proposed change is a good idea. 2. This seems like it has some unrelated changes in it, which look worthwhile, but they should be in a separate

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma updated this revision to Diff 66694. maximma added a comment. Fixed display of numbersА REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24146?vs=66625=66694 BRANCH calculatorApplet (branched from master) REVISION DETAIL

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. maximma requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH calculatorApplet (branched from master) REVISION DETAIL https://phabricator.kde.org/D24146 AFFECTED