This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ca085f500183: Add per-origin media controls blacklist
(authored by broulik).
REPOSITORY
R856 Plasma Browser
broulik updated this revision to Diff 67492.
broulik added a comment.
- i18n for popup
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24194?vs=66924=67492
REVISION DETAIL
https://phabricator.kde.org/D24194
AFFECTED FILES
broulik added a comment.
Ping
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D24194
To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin,
broulik added inline comments.
INLINE COMMENTS
> fvogt wrote in action_popup.js:217
> Does this also hit all the frames inside?
Effectively, yes. It asks the extension.js whether it knows any players on the
given tab, which will include all frames, see the actual implementation of
fvogt added inline comments.
INLINE COMMENTS
> action_popup.js:217
> +TabUtils.getCurrentTab().then((tab) => {
> +return sendMessage("mpris", "hasTabPlayer", {
> +tabId: tab.id
Does this also hit all the frames inside?
REPOSITORY
R856 Plasma
broulik updated this revision to Diff 66924.
broulik edited the test plan for this revision.
broulik added a comment.
- Show media controls only if there is a player or something blacklisted on
that page, otherwise it gets annoying
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE
broulik updated this revision to Diff 66907.
broulik retitled this revision from "Add per-domain media controls blacklist"
to "Add per-origin media controls blacklist".
broulik edited the summary of this revision.
broulik added a comment.
- Work on origin rather than hostname
- Merge
