D24208: [Notifications] Dodge Plasma dialogs

2019-10-16 Thread Nathaniel Graham
ngraham added a comment. In D24208#548315 , @meven wrote: > In D24208#548272 , @ngraham wrote: > > > In D24208#548153 , @broulik wrote: > > > > >

D24208: [Notifications] Dodge Plasma dialogs

2019-10-16 Thread Kai Uwe Broulik
broulik added a comment. > Hidding the notification behind a popup is at best a workaround. It is. > What if you receive an email while changing your audio setup ? Then you close the popup and get the notification, I don't see an issue with that. It's not like you fiddle with

D24208: [Notifications] Dodge Plasma dialogs

2019-10-16 Thread Méven Car
meven added a comment. In D24208#548272 , @ngraham wrote: > In D24208#548153 , @broulik wrote: > > > Bluetooth could provide some better feedback inside the plasmoid. > > > Agreed,

D24208: [Notifications] Dodge Plasma dialogs

2019-10-16 Thread Nathaniel Graham
ngraham added a comment. In D24208#548153 , @broulik wrote: > Bluetooth could provide some better feedback inside the plasmoid. Agreed, notifications shouldn't be used when the app/window/UI/whatever is still open; feedback should be

D24208: [Notifications] Dodge Plasma dialogs

2019-10-16 Thread Kai Uwe Broulik
broulik added a comment. Bluetooth could provide some better feedback inside the plasmoid. Pointless confirmation notifications in plasma-nm were the main reason for this patchset. Sliding could be done but is a lot more complicated than this patchset since the dialogs are individual,

D24208: [Notifications] Dodge Plasma dialogs

2019-09-27 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc0c125479d4: [Notifications] Dodge Plasma dialogs (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24208?vs=66793=66940 REVISION

D24208: [Notifications] Dodge Plasma dialogs

2019-09-27 Thread Marco Martin
mart accepted this revision. mart added a comment. this may be good in both .17 and master, then to see if is possible, only in master to actually move the notivications out of the way REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24208 To: broulik,

D24208: [Notifications] Dodge Plasma dialogs

2019-09-27 Thread Marco Martin
mart added a comment. In D24208#538239 , @ngraham wrote: > This works great! > > Instead of temporarily hiding the pop-ups, maybe it should appear above the dialog? Not a huge deal though. > > 5.17 branch? would make sense...

D24208: [Notifications] Dodge Plasma dialogs

2019-09-26 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works great! Instead of temporarily hiding the pop-ups, maybe it should appear above the dialog? Not a huge deal though. 5.17 branch? REPOSITORY R120 Plasma Workspace

D24208: [Notifications] Dodge Plasma dialogs

2019-09-24 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The notification popup typically gets in the way of the system tray popup. In case it would