D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. Since we plan to move more GTK related code to kde-gtk-config repo (specifically coloration of GTK apps from krdb), isn't it more reasonable to put this module in kde-gtk-config repo? REPOSITORY R98 Breeze for Gtk BRANCH arcpatch-D24275_1 REVISION DETAIL https

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75856. cblack added a comment. Lower min version of CMake REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=75205&id=75856 BRANCH arcpatch-D24275_1 REVISION DETAIL https://phabricator.kde.org/D24275 AF

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) As noticed by @The-Feren-OS-Dev, this is too high. REPOSITORY R98 Breeze for Gtk BRANCH arcpatch-D24275_1 REVISION DETAIL https://phabricator.kde.

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. Had to lower the cmake version requirement to be able to compile this, but this works just fine, and it's definitely something that'd be nice to have. I can't see any re

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in reloader.c:26 > What is this 801? GTK loads in the original colors.css at priority 800, so priority 801 will override it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack marked an inline comment as done. cblack added a comment. Looking at documentation, the colour module should gracefully fail when it's unable to locate the colors.css, however I have not tested this. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24275

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

davidedmundson added a comment. This would also be loaded and operational when running in a gnome session. It's important we don't cause issues there. Does this work if colours.css doesn't exist and is then created at runtime? INLINE COMMENTS > reloader.c:26 > +801 > +); > +

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75205. cblack added a comment. Fix memory leak REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=75203&id=75205 BRANCH arcpatch-D24275_1 REVISION DETAIL https://phabricator.kde.org/D24275 AFFECTED FILE

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 75203. cblack added a comment. Drop meson.build, clean CMakeLists.txt, rebase on master REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=70834&id=75203 BRANCH arcpatch-D24275_1 REVISION DETAIL https://

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

nicolasfella added a comment. Unrelated to the issue: For GLIB2 we have a ECM find module that makes things a bit nicer. See https://invent.kde.org/snippets/601 For GOBJECT we don't have one, but since we afaik use it on at least one other place it might be worth making one REPOSITORY R9

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 70834. cblack added a comment. Pull from master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=66974&id=70834 BRANCH color-reload-module (branched from master) REVISION DETAIL https://pha

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added a comment. Needs a rebase on current master. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexe

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. In D24275#571532 , @cblack wrote: > In D24275#571531 , @GB_2 wrote: > > > Works now :-) > > > With the cmake or the meson? Meson. REPOSITORY R99 KDE Gtk Configur

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D24275#571531 , @GB_2 wrote: > Works now :-) With the cmake or the meson? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ng

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. Works now :-) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliez

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D24275#546111 , @GB_2 wrote: > In D24275#538994 , @cblack wrote: > > > Does it work if you use an absolute path to the library? Go to `$BUILDROOT/color-reload-module/libcol

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. In D24275#538994 , @cblack wrote: > Does it work if you use an absolute path to the library? Go to `$BUILDROOT/color-reload-module/libcolorreload-gtk-module.so` and run `gedit --gtk-module $PWD/libcolorreload-gtk-module.so`

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. Does it work if you use an absolute path to the library? Go to `$BUILDROOT/color-reload-module/libcolorreload-gtk-module.so` and run `gedit --gtk-module $PWD/libcolorreload-gtk-module.so` REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricat

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added a comment. $ gedit --gtk-module colorreload-gtk-module Gtk-Message: 17:44:24.968: Failed to load module "colorreload-gtk-module" What am I doing wrong? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasm

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The title is somewhat self explanatory. TEST PLAN `gtk-app-here --gtk-module colorreload-gtk-modul