D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-16 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:03ce6234aa96: [Weather data engine] Handle windy conditions in NOAA backend (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-16 Thread Nathaniel Graham
ngraham added a comment. Nice. The icons should go in today, after which I'll land this. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-15 Thread Shawn Starr
spstarr added a comment. When those land I'll have a PR for EnvCan provider/ion to support those too REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Shawn Starr
spstarr added a comment. Awesome! REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Shawn Starr
spstarr added a comment. I note for Environment Canada they have these Night Blowing snow: https://weather.gc.ca/weathericons/40.gif Day Blowing snow: https://weather.gc.ca/weathericons/25.gif Day and night(?) windy: https://weather.gc.ca/weathericons/43.gif Blowing smoke (day and

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Nathaniel Graham
ngraham added a comment. Yeah there are windy and rainy conditions too. I expect we can handle those as well once we get appropriate icons. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Shawn Starr
spstarr added a comment. Now I'm wondering if I can get a blowing snow icon ;) REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Nathaniel Graham
ngraham added a comment. Thanks! I'll wait for the icon patch to land before landing this. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-11 Thread Shawn Starr
spstarr added a comment. Still looks good to me REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 67640. ngraham added a comment. Remove old unused enum from the first revision REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24483?vs=67639=67640 BRANCH windy (branched from master) REVISION DETAIL

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 67639. ngraham added a comment. Handle windy + cloudy conditions as well now that we have appropriate icons REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24483?vs=67474=67639 BRANCH windy (branched from

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Nathaniel Graham
ngraham added a comment. In D24483#544500 , @spstarr wrote: > 'breez' or breeze' just curious here That's to match both "breeze" and "breezy". I'll wait to land this until we get a real `weather-wind` icon. REPOSITORY R120 Plasma

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Shawn Starr
spstarr added a comment. We do need another icon, Wind would be generic for Dust storm, or Blowing smoke, Blowing snow in this case. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Shawn Starr
spstarr added a comment. 'breez' or breeze' just curious here REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Shawn Starr
spstarr added a comment. No degree, but I have been following weather for years and on some mailing lists with meteorologists. 'Wind' can be a weather condition especially if its a dust storm. If NOAA lists it as a weather condition. I think this is fine. In Canada we do have Wind

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Nathaniel Graham
ngraham added a comment. I'm not sure I really understand the proposal. As far as I'm aware, you're the maintainer, so I'll accept with your wishes. All I really care about is that my weather forecast stops looking like this all the time: :-) F7557163: Screenshot_20191009_095550.png

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24483#544263 , @ngraham wrote: > To me it makes conceptual sense to display windiness when it's not including other severe weather conditions. In those cases, you care more about the other conditions than the fact

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Nathaniel Graham
ngraham added a comment. To me it makes conceptual sense to display windiness when it's not including other severe weather conditions. In those cases, you care more about the other conditions than the fact that it's also windy. For example if the wind accompanies rain or a storm, the fact

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24483#544189 , @ngraham wrote: > Where I live (in the desert), we often have days that are very windy with no clouds or rain, especially in the springtime. On such days, the data engine always falls back to

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Nathaniel Graham
ngraham added a comment. Where I live (in the desert), we often have days that are very windy with no clouds or rain, especially in the springtime. On such days, the data engine always falls back to `IonInterface::NotAvailable`, which is not accurate; a forecast //is// available, but we're

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. Disclaimer: nowhere a meteorologist myself, kitchen talk quality at best :) I have to tell I have no idea how "wind" actually matches the category and what general cloud/sky conditions could be derived. Where I have lived, wind as in: fast moving air masses

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-07 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: kossebau, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now windy conditions are not handled at all. I live in an area with very frequent