This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fec538fb02e0: Delegate KCM cursor theme config management
to KConfigXT (authored by bport).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
bport updated this revision to Diff 67949.
bport added a comment.
Add notify to setPreferredSize
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24519?vs=67606=67949
REVISION DETAIL
https://phabricator.kde.org/D24519
AFFECTED FILES
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmcursortheme.cpp:157
> {
> -return m_selectedThemeRow;
> -}
> -
> -void CursorThemeConfig::setSelectedSizeRow(int row)
> -{
> -Q_ASSERT (row <
bport updated this revision to Diff 67606.
bport added a comment.
Take in consideration feedbacks
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24519?vs=67561=67606
REVISION DETAIL
https://phabricator.kde.org/D24519
AFFECTED FILES
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmcursortheme.cpp:335
>
> +int CursorThemeConfig::cursorSizeIndex(const int cursorSize) const
> +{
int, not const inst
> kcmcursortheme.cpp:349
>
> -void
bport added inline comments.
INLINE COMMENTS
> davidedmundson wrote in main.qml:99
> I think this will be broken if you change this combo box, then change theme.
>
> When a user explicitly changes this combo box this binding gets broken with
> currentIndex now reflecting an explicit number.
>
davidedmundson added inline comments.
INLINE COMMENTS
> main.qml:99
> textRole: "display"
> +currentIndex:
> kcm.cursorSizeIndex(kcm.cursorThemeSettings.cursorSize);
> onActivated: {
I think this will be broken if you change this
bport created this revision.
bport added reviewers: Plasma, mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D24519
AFFECTED FILES
