D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-16 Thread Aleix Pol Gonzalez
apol added a comment. I'll insist, this KCM is distributed by Plasma. An Okular user on Windows won't have it available, this makes for tendentious data. Even with Plasma users, the process of explaining people "you have to go to enable it in system settings, then you go to enable it

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-15 Thread Nathaniel Graham
ngraham added a comment. In D24635#547820 , @apol wrote: > I understand what you say but I don't think that's even feasible. Does it really make sense that from e.g. KMail you need to ask the Plasma KCM for permission to send feedback? >

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-15 Thread Aleix Pol Gonzalez
apol added a comment. > Ok, just tried this out. The problem is that the global on/off switch that's presented to the user is still reversed from what it should be: instead of saying, "forbid KDE software from bla bla bla", it should say "allow KDE software to bla bla bla". Otherwise the

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-15 Thread Nathaniel Graham
ngraham added a comment. In D24635#547168 , @apol wrote: > In D24635#547136 , @ngraham wrote: > > > Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread Aleix Pol Gonzalez
apol added a comment. In D24635#547136 , @ngraham wrote: > Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than additionally allow turning telemetry on or off for apps and Plasma. That seems like it might

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread Nathaniel Graham
ngraham added a comment. Thanks. Can we just surface that then? We'd show a UI for the global on/off switch and than additionally allow turning telemetry on or off for apps and Plasma. That seems like it might be less confusing than coming up with an abstraction surrounding it. REPOSITORY

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread David Edmundson
davidedmundson added a comment. > If the framework doesn't really support this To hopefully clarify, the framework works as follows: Global Enabled | App Enabled* | Result off |off | off off |on

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread Nathaniel Graham
ngraham added a comment. I would really prefer a for the UX to indicate that that telemetry is off by default and needs to be manually turned on, or else it's confusing and disconcerting to the user. If the framework doesn't really support this, then we should change the implementation in

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread David Edmundson
davidedmundson added a comment. Implementation wise, that seems to match what now kuserfeedback clearly in mind, so ++. UX wise, I'm not completely sold. It still sounds like it's on by default till you read the long explanatory text to explain that just because it's not not disabled

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

2019-10-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show the kill switch as such. It's about fordbidding all applications to submit data. They will be