This revision was automatically updated to reflect the committed changes.
Closed by commit R130:8339cba19e9a: [KWindowSystem] in icon() return realistic
icon size (authored by meven).
REPOSITORY
R130 Frameworks integration plugin using KWayland
CHANGES SINCE LAST UPDATE
meven marked 2 inline comments as done.
meven added a comment.
Anyone to care to review and accept this small code change ?
REPOSITORY
R130 Frameworks integration plugin using KWayland
REVISION DETAIL
https://phabricator.kde.org/D24683
To: meven, #kwin, davidedmundson
Cc:
meven marked 5 inline comments as done.
meven added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in windowsystem.cpp:173
> That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you
> got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2
>
anthonyfieroni added inline comments.
INLINE COMMENTS
> meven wrote in windowsystem.cpp:173
> @anthonyfieroni Hey Anthony
> Do you remember where the if comparison width values come from in your commit
> https://cgit.kde.org/kwindowsystem.git/commit/?id=e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f
meven added a subscriber: anthonyfieroni.
meven added a comment.
ping @zzag @mart Any feedback
INLINE COMMENTS
> meven wrote in windowsystem.cpp:173
> I can't explain the current logic.
>
> @mart Do you think I should change the logic to give it more sense ?
>
> Perhaps make the 24, 40..
meven added inline comments.
INLINE COMMENTS
> meven wrote in windowsystem.cpp:173
> It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp
> So I don't know precisely but at least it is coherent with X.
> Unfortunately the commit history does not tell much.
I can't explain the
meven added inline comments.
INLINE COMMENTS
> mart wrote in windowsystem.cpp:173
> what's the logic behind the numbers 40, 56, 96 ans 192?
> should at least be in a comment
It was copied from kwindowsystem/src/platforms/xcb/kwindowsytem.cpp
So I don't know precisely but at least it is coherent
mart added inline comments.
INLINE COMMENTS
> windowsystem.cpp:173
> +iconWidth = 16;
> +} else if (width < 40) {
> +iconWidth = 32;
what's the logic behind the numbers 40, 56, 96 ans 192?
should at least be in a comment
REPOSITORY
R130 Frameworks integration plugin using
meven updated this revision to Diff 68022.
meven marked an inline comment as done.
meven added a comment.
Actually use the scaled pixmap
REPOSITORY
R130 Frameworks integration plugin using KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24683?vs=68012=68022
BRANCH
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in windowsystem.cpp:188
> You forgot to assign the copied pixmap to something. However, I think you
> could just return it from this point.
edit: scaled pixmap
REPOSITORY
R130 Frameworks integration plugin using KWayland
REVISION
zzag added inline comments.
INLINE COMMENTS
> windowsystem.cpp:188
> +if (scale) {
> +pixmap.scaled(width, height, Qt::IgnoreAspectRatio,
> Qt::SmoothTransformation);
> +}
You forgot to assign the copied pixmap to something. However, I think you could
just return
meven added a subscriber: ngraham.
meven added a comment.
@ngraham In Wayland this allows the Tooltips from the taskmanager to display
centered icon for wayland windows.
REPOSITORY
R130 Frameworks integration plugin using KWayland
REVISION DETAIL
https://phabricator.kde.org/D24683
To:
meven updated this revision to Diff 68012.
meven added a comment.
Clean up
REPOSITORY
R130 Frameworks integration plugin using KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24683?vs=68011=68012
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24683
meven created this revision.
meven added reviewers: KWin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
The icon function did not take into account the fact that icons have limited
size options
14 matches
Mail list logo
