D24727: Fix NOAA picture of the day provider

This revision was automatically updated to reflect the committed changes. Closed by commit R114:432470576605: Fix NOAA picture of the day provider (authored by Guo Yunhe ). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68225&i

D24727: Fix NOAA picture of the day provider

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. works well enough it seems F7622741: yJIMcaK.jpg REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D247

D24727: Fix NOAA picture of the day provider

ngraham added a comment. If it works for you @sitter then feel free to ignore me. But I believe my testing methodology is sound: I'm living in my built-from-source plasma session and I apply the patch, build and install kdeplasma-addons to `~/kde/usr`, and then restart plasmashell. This work

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68225. guoyunhe added a comment. Validate QUrl of image REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68185&id=68225 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24727 AFFECTED FILE

D24727: Fix NOAA picture of the day provider

sitter added a comment. When I put the code in a minimal standalone program I can confirm that the code works just fine. Are you sure your testing methodology is sound @ngraham ? In point of fact if (url.isEmpty()) { should actually be `url.isValid` because the requirement is

D24727: Fix NOAA picture of the day provider

ngraham added a comment. I don't know what to tell you; it's still broken for me. It looks like the first part of the URL isn't getting added onto the second, maybe. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyunhe, #plasma Cc: ngraham, plasm

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549327 , @ngraham wrote: > Still broken, I'm afraid. Among the console output is the following, which may be helpful: > > kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg") >

D24727: Fix NOAA picture of the day provider

ngraham added a comment. Still broken, I'm afraid. Among the console output is the following, which may be helpful: kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg") REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyun

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68185. guoyunhe edited the summary of this revision. guoyunhe added a comment. Change back to the original page URL REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68126&id=68185 BRANCH master REVISIO

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549199 , @ngraham wrote: > This doesn't fix the problem for me. :( Can you run `plasmashell --replace` in terminal and check the error output? REPOSITORY R114 Plasma Addons REVISION DETAIL https://

D24727: Fix NOAA picture of the day provider

ngraham added a comment. This doesn't fix the problem for me. :( REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himc

D24727: Fix NOAA picture of the day provider

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The webpage structure of NOAA changed so the old regular expression doesn't work anymore. Updated it. But it can break in future