D24744: Remove unneeded options in GTK KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R99:e3274dba5fb2: Remove unneeded options in GTK KCM (authored by gikari, committed by ngraham). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?v

D24744: Remove unneeded options in GTK KCM

ngraham accepted this revision. ngraham added a subscriber: apol. ngraham added a comment. This revision is now accepted and ready to land. @apol, are you good with this? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-kcm-remove-unneeded-options REVISION DETAIL https://phabricato

D24744: Remove unneeded options in GTK KCM

gikari updated this revision to Diff 69779. gikari added a comment. Rebase on new master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68286&id=69779 BRANCH gtk-kcm-remove-unneeded-options REVISION DETAIL https://phabricato

D24744: Remove unneeded options in GTK KCM

gikari planned changes to this revision. gikari added a comment. In D24744#562640 , @ngraham wrote: > Can you rebase this? Sure REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari,

D24744: Remove unneeded options in GTK KCM

ngraham added a comment. Can you rebase this? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk,

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. Ok, then we should keep it in the GTK KCM until we have the option for Qt applications. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGast00

D24744: Remove unneeded options in GTK KCM

ngraham added a comment. "Absolutely not" is right. We can't remove this option entirely; that would be a big regression. If not all apps respect it, we need to fix those apps. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg,

D24744: Remove unneeded options in GTK KCM

broulik added a comment. > remove it from the view and always set it to "one page per click"? Absolutely not. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel, LeGa

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. I'd be fine with that (we could always add it later in the Application Style KCM when we have it for Qt). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plas

D24744: Remove unneeded options in GTK KCM

gikari added a comment. In D24744#550210 , @ngraham wrote: > In D24744#549568 , @broulik wrote: > > > Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to p

D24744: Remove unneeded options in GTK KCM

ngraham added a comment. In D24744#549568 , @broulik wrote: > Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to position radios Yeah I'm working on exposing that for QWidgets apps in the Genera

D24744: Remove unneeded options in GTK KCM

gikari updated this revision to Diff 68286. gikari added a comment. - Remove unneeded find_package of deprecated library REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68285&id=68286 BRANCH gtk-kcm-remove-unneeded-options REVI

D24744: Remove unneeded options in GTK KCM

gikari updated this revision to Diff 68285. gikari added a comment. Rebase on top of modified D24743 REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24744?vs=68189&id=68285 BRANCH gtk-kcm-remove-unnee

D24744: Remove unneeded options in GTK KCM

broulik added a comment. Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to position radios REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: broulik, filipf, GB_2, plasm

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549486 , @gikari wrote: > In D24744#549450 , @GB_2 wrote > > > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

D24744: Remove unneeded options in GTK KCM

gikari added a comment. In D24744#549450 , @GB_2 wrote > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM. Where would gtk theme installation buttons go? REPOSITORY R99 KDE Gtk Confi

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549444 , @filipf wrote: > So much nicer, awesome work. +1 for the visuals of the rehauled kcm. Well, it'll be gone completely soon and the GTK theme comboboxes are going to be in the Application Style KCM.

D24744: Remove unneeded options in GTK KCM

filipf added a comment. So much nicer, awesome work. +1 for the visuals of the rehauled kcm. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkin

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. Wow, it's so empty now! Great job! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himce

D24744: Remove unneeded options in GTK KCM

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since font, icons, cursor theme, toolbar style, icons in menus and buttons settings are now in sync with corresponding plasma setting