D24798: Migrate QQC1 to QQC2

lbeltrame added a comment. Fixed in 47c76ebc83ee1f96c7a5fd9be23c6234a93143e8 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces,

D24798: Migrate QQC1 to QQC2

lbeltrame added a comment. This change breaks SDDM theme loading. See https://bugs.kde.org/show_bug.cgi?id=414252. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces, ngraham Cc: lbeltrame, davidedmundson, GB_2,

D24798: Migrate QQC1 to QQC2

davidedmundson added inline comments. INLINE COMMENTS > configTimeZones.qml:21-22 > > -import QtQuick 2.0 > -import QtQuick.Controls 1.2 as QtControls > +import QtQuick 2.13 > +import QtQuick.Controls 2.13 as QQC2 > import QtQuick.Layouts 1.0 Next plasma release can only depend on Qt 5.12

D24798: Migrate QQC1 to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b7b25010aa58: Migrate QQC1 to QQC2 (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69739=69763 REVISION

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. I also tried to not use ScrollView but enable ListView's scrollbar: ListView { // add scrollbar, background and border clip: true flickableDirection: Flickable.VerticalFlick boundsBehavior: Flickable.StopAtBounds

D24798: Migrate QQC1 to QQC2

GB_2 added a comment. In D24798#562431 , @guoyunhe wrote: > Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. Yeah, that is a general

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69739. guoyunhe added a comment. Thanks for the tip. It seems added the border, but when scrolling, the top border or bottom border disappear. It cannot show full border at all sides. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24798: Migrate QQC1 to QQC2

ahiemstra added a comment. In D24798#562333 , @guoyunhe wrote: > Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager: > > F7762797: image.png

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69730. guoyunhe added a comment. Enable keyboard navigation and proper highlight REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69705=69730 BRANCH master REVISION DETAIL

D24798: Migrate QQC1 to QQC2

guoyunhe added a comment. Maybe the border of ScrollView is missing in breeze theme. I checked some other widgets, like network manager: F7762797: image.png It also miss the border in the connection list. REPOSITORY R120 Plasma Workspace

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69705. guoyunhe added a comment. Prefix QQC2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69703=69705 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks. Still needs fixes for the timezone list: - No frame around list - Scrolling using touchpad or mouse wheel does not work - Scrollview bounds are too large -

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69703. guoyunhe added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69701=69703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

ngraham added a comment. Needs a rebase, and Kai's comment still needs to be addressed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces, ngraham Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n,

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69701. guoyunhe added a comment. Add QQC2 namespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68733=69701 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

broulik added a comment. That new time zone view lacks any form of keyboard navigation. I cannot use arrow keys to navigate it and neither can I hit space to toggle a checkbox. It also lacks a frame around its content area like the text field has. REPOSITORY R120 Plasma Workspace

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 68733. guoyunhe added a comment. Merge kmaterka's patch D24853 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68345=68733 BRANCH master REVISION DETAIL

D24798: Migrate QQC1 to QQC2

kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:53 > While you're doing some porting, this entire thing can be replaced with a > `Kirigami.InlineMessage` which will drastically reduce the amount of code > here, and you can also remove the

D24798: Migrate QQC1 to QQC2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. ++. The new table in the clock settings is much nicer anyway. :) See the following inline comments: INLINE COMMENTS > configTimeZones.qml:22 > import QtQuick 2.0 > -import

D24798: Migrate QQC1 to QQC2

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change. REPOSITORY