D24894: notifier: Make action buttons translatable

aspotashev added a comment. In D24894#554481 , @yurchor wrote: > A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: > > https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBac

D24894: notifier: Make action buttons translatable

aspotashev added a comment. In D24894#554481 , @yurchor wrote: > A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: > > https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBac

D24894: notifier: Make action buttons translatable

yurchor added a comment. A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141: https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141 Can it be fixed as well? Thanks in advance for y

D24894: notifier: Make action buttons translatable

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d877aa09ba17: notifier: Make action buttons translatable (authored by aspotashev). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24894?vs=68625&id=

D24894: notifier: Make action buttons translatable

apol accepted this revision. apol added a comment. Good catch! I wonder how that happened :/ REPOSITORY R134 Discover Software Store BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/D24894 To: aspotashev, apol, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS

D24894: notifier: Make action buttons translatable

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.17 branch please. While you cannot change strings, you can make previously accidentally untranslated strings translatable. REPOSITORY R134 Discover Software Store BRANCH notifier-i

D24894: notifier: Make action buttons translatable

aspotashev updated this revision to Diff 68625. aspotashev added a comment. oops, sent wrong patch REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24894?vs=68624&id=68625 BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/

D24894: notifier: Make action buttons translatable

aspotashev created this revision. aspotashev added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.