D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R120:d029fb058cff: [Lock Screen] Don't use black shadows with black text (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24997?vs=68868&id=

D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Fabian Vogt
fvogt added a comment. In D24997#555258 , @ngraham wrote: > I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these ki

D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. All right let's do this as a targeted fix for 5.17. REPOSITORY R120 Plasma Workspace BRANCH black-text-no-black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D24997 To: filipf, #plasma, #vdg, ngraham,

D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Filip Fila
filipf added a comment. Yeah there is a conceptual issue here we need to look into solving. IMO we should just always have white UI elements and the background dimmed. As for solutions, I've already looked into hardcoding everything as white (+bg dimmed). It's easy to fix the wallpaper f

D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Nathaniel Graham
ngraham added a comment. I think we have a greater conceptual problem here. If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these kinds of problems. I see two practical solutions: - Hardcode white as the text c

D24997: [Lock & Login Screens] Don't use a black shadow with black text

2019-10-28 Thread Filip Fila
filipf added a comment. Admittedly this doesn't look super fortuate either when the wallpaper is darker: F7677168: image.png But legibility is really poor unless we do something: F7677180: image.png